fix: Remove null caching for invalid language lookup#196
Open
PantherX99 wants to merge 4 commits into
Open
Conversation
Stop caching null values for languages because they might get created afterwards in the converters.
Author
|
This also applies to the TranslationConverter in which translations are not being created due to a null value from the languageLookup |
Member
|
PantherX99 thanks for this one too 👍 Can you add a test? |
Author
|
Jozsef Damokos (@jozsefdamokos) Like this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop caching null values for languages because they might get created afterwards in the converters.
If null values are cached, converters are using inconsistent data.
Example:
An different solution would be calling
$this->languageLookup->reset();after the langauge was created in the LanguageConverter. Then all languages would need to be cached again. This has to be called everywhere, when a new language is created. I would think, having invalid locales is highly unlikely, so not caching null values would not result in performance issues.