Improve observability for the app registration flow by adding structu…#60
Draft
Leon Beckamp (leonbeckamp) wants to merge 1 commit into
Draft
Improve observability for the app registration flow by adding structu…#60Leon Beckamp (leonbeckamp) wants to merge 1 commit into
Leon Beckamp (leonbeckamp) wants to merge 1 commit into
Conversation
…red logging around key registration phases This adds log events for: - registration start before signature verification - registration preparation after shop creation/update - confirmation start before confirmation signature verification - secret rotation during confirmation - final registration confirmation A small `registrationLogContext()` helper keeps the logged context consistent across these events. The context includes shop identity and state flags such as whether the shop exists,is confirmed, has a pending secret, or has a previous secret. - Ran `php -l src/Registration/RegistrationService.php` - Confirmed no syntax errors
Leon Beckamp (leonbeckamp)
force-pushed
the
add/log-registration-process-signature
branch
from
48999d7 to
666fa9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve observability for the app registration flow by adding structured logging around key registration phases.
This adds log events for:
A small
registrationLogContext()helper keeps the logged context consistent across these events. The context includes shop identity and state flags such as whether the shop exists, is confirmed, has a pending secret, or has a previous secret.