feat: improve downstream identification#146
Merged
Merged
Conversation
Florian Ruppel (fruppel)
requested review from
Marcel Kräml (mkraeml) and
Soner (shyim)
Member
|
We should maybe think about creating a GitHub App which triggers those pipelines and we get notified when they are done. So we dont waste CI resources with polling and can do prober PR checks 👀 |
Contributor
Author
|
Thanks Soner (@shyim) makes sense to me. I would suggest to merge this PR because it already helps first and refactor it to a Github App in the next step |
Soner (shyim)
approved these changes
May 27, 2026
Member
|
sure. I won't blocked it :) |
Marcel Kräml (mkraeml)
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub CLI now returns the URL of the triggered workflow run when calling
gh workflow run. We capture this URL in the trigger step and pass it directly towait.bash.This removes the previous heuristic search - listing recent workflow dispatches filtered by date and matching them by job step name or log content - along with the
NEW_LOGICflag and its retry loop that guarded it. The script now goes straight to polling the correct run for its completion status.