Use appropriate reload method for Py2 or Py3 in tank_api_proxy#855
Open
jlucas wants to merge 1 commit intoshotgunsoftware:masterfrom
Open
Use appropriate reload method for Py2 or Py3 in tank_api_proxy#855jlucas wants to merge 1 commit intoshotgunsoftware:masterfrom
jlucas wants to merge 1 commit intoshotgunsoftware:masterfrom
Conversation
Avoiding use of the six.py module, since it may not be present in the user's environment at the time this proxy is imported.
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
==========================================
- Coverage 79.39% 72.83% -6.56%
==========================================
Files 177 177
Lines 19303 19303
==========================================
- Hits 15325 14059 -1266
- Misses 3978 5244 +1266
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use a setup where the SGTK Pipeline Configuration is on disk, local to each Project. We put
install/core/pythononto$PYTHONPATHto enableimport sgtk. In the process of transitioning to Python 3 we found these incompatible Python 2reloadcalls.The problem could be solved with
six.moves.reload_moduleinstead, but I don't know if you want to expect/force the user to have that library in their base environment since it is not part of the standard library.