Add V1 endpoints for factory, machine, machine_type

[mks-sight]

Hi, Please review the PR, Thanks

https://sightmachine.atlassian.net/browse/MARS-7090

[mklein0]

Could unit tests against https://demo-continuous.sightmachine.io/ be added? I think we can have basic username/password added to that tenant. We wouild just need to add the password for our list of secrets in repo, so if it needs to be changed we are aware of it.

[mklein0]

A test using mocks against the requests library can be done with: https://requests-mock.readthedocs.io/en/latest/mocker.html

[mks-sight]

A test using mocks against the requests library can be done with: https://requests-mock.readthedocs.io/en/latest/mocker.html

Are we looking for new way of mocking request since monkeypatch of mock is already there or we are looking for an INTEGRATION test to test sdk code end to end

for eg.

`def test_get_machines(monkeypatch):
# Setup
def mockapi(self, session, endpoint):
if endpoint == "/api/machine":
return pd.DataFrame(JSON_MACHINE)
return pd.DataFrame()

monkeypatch.setattr(Machine, "get_machines", mockapi)

dt = Machine(Session(), "demo")

# Run
df = dt.get_machines(Session(), "/api/machine")

# Verify
assert df.shape == (27, 7)

cols = [
    "factory_location",
    "factory_partner",
    "id",
    "metadata",
    "source",
    "source_clean",
    "source_type",
]

assert cols == df.columns.sort_values().tolist()

`

in this code we are mocking, do we need to add more tests like this or do we need to use the sdk to test against demo-continuos from an end-user perspective?
Thanks

[mks-sight]

A test using mocks against the requests library can be done with: https://requests-mock.readthedocs.io/en/latest/mocker.html

we are creating a separate ticket for this

[mks-sight]

A test using mocks against the requests library can be done with: https://requests-mock.readthedocs.io/en/latest/mocker.html

we are creating a separate ticket for this

[mks-sight]

Could unit tests against https://demo-continuous.sightmachine.io/ be added? I think we can have basic username/password added to that tenant. We wouild just need to add the password for our list of secrets in repo, so if it needs to be changed we are aware of it.

we are creating a separate ticket for this

[mklein0]

FYI, It it the way the current SDK is designed, but I dislike the need to need to inspect the method names to determine function signatures rather than leveraging the language and OO methods.

[mklein0]

Unit Tests are a separate PR?

[mklein0]

A useful combination of tools to see how well the code created has test coverage is:

• coverage
• diff-cover

ex.

coverage run -m pytest -vvv -s  tests
coverage xml
diff-cover --compare-branch origin/master --html-report diff-report.html coverage.xml
xdg-open diff-report.html

The report given goes off the code vs the diff, but still useful.

[harshmishraintg]

I don't have any more comments on this. Approved

[mgoldmansight]

I might be missing something but it seems like all of these modify_input_params are the same. Is there a reason this isn't a util you import?

[mklein0]

What does mongo in the function name mean?

[mklein0]

What is this module kept around for? What v0 interfaces remain?