Don't try to run tests from SIL.LCModel.Utils.Tests#420
Merged
jasonleenaylor merged 2 commits intodevelopfrom Dec 11, 2024
Merged
Don't try to run tests from SIL.LCModel.Utils.Tests#420jasonleenaylor merged 2 commits intodevelopfrom
jasonleenaylor merged 2 commits intodevelopfrom
Conversation
Test Results554 tests - 327 554 ✅ - 213 3m 25s ⏱️ -1s Results for commit f8b20bb. ± Comparison against base commit 2dcbbb7. This pull request removes 881 and adds 554 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jasonleenaylor
force-pushed
the
chore/excludeLCMTests
branch
from
58e9bee to
7089a2f
Compare
* Exclude the SIL.LCModel.Utils.Tests.dll since that is a utility dll that has tests in it
jasonleenaylor
force-pushed
the
chore/excludeLCMTests
branch
from
7089a2f to
ee0c11c
Compare
hahn-kev
approved these changes
Dec 11, 2024
Contributor
hahn-kev
left a comment
hahn-kev
left a comment
There was a problem hiding this comment.
looks good to me, I left a suggestion, but I'm not super sure if it'll work so feel free to discard it. I tried it and got an error I didn't really understand, but I'm not sure if that's just my environment.
| OutputXmlFile="$(RootDir)/output/$(Configuration)/$(TargetFramework)/TestResults.xml" | ||
| TeamCity="$(TeamCity)"/> | ||
| <!-- Loop over each TestAssembly and execute dotnet test --> | ||
| <Exec Command="dotnet test --no-build --verbosity detailed --logger "trx;LogFileName=%(TestAssemblies.Filename)TestResults.trx" --filter "TestCategory!=$(ExtraExcludeCategories)" "%(TestAssemblies.FullPath)"" |
Contributor
There was a problem hiding this comment.
escaping stuff sucks, could you do this instead?
Suggested change
| <Exec Command="dotnet test --no-build --verbosity detailed --logger "trx;LogFileName=%(TestAssemblies.Filename)TestResults.trx" --filter "TestCategory!=$(ExtraExcludeCategories)" "%(TestAssemblies.FullPath)"" | |
| <PropertyGroup> | |
| <_RunTestsCommand>dotnet test --no-build --verbosity detailed --logger "trx;LogFileName=%(TestAssemblies.Filename)TestResults.trx" --filter "TestCategory!=$(ExtraExcludeCategories)" "%(TestAssemblies.FullPath)"</_RunTestsCommand> | |
| </PropertyGroup> | |
| <!-- Loop over each TestAssembly and execute dotnet test --> | |
| <Exec Command="$(_RunTestsCommand)" |
I'm not too familiar with msbuild so I'm not sure if that would work but it would be much more maintinable
Contributor
Author
There was a problem hiding this comment.
Yeah, escaping stuff isn't my favorite, but in this case I think it is necessary.
Your suggestion wouldn't work because it would defeat the batching. Actually, the error you got is probably because the metadata expansion isn't valid in a PropertyGroup.
https://learn.microsoft.com/en-us/visualstudio/msbuild/item-metadata-in-task-batching?view=vs-2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is