LT-22388: Fix NullReferenceException in UnitOfWorkService.SaveOnIdle#361
Open
johnml1135 wants to merge 1 commit intosillsdev:masterfrom
Open
LT-22388: Fix NullReferenceException in UnitOfWorkService.SaveOnIdle#361johnml1135 wants to merge 1 commit intosillsdev:masterfrom
johnml1135 wants to merge 1 commit intosillsdev:masterfrom
Conversation
Add an early IsDisposed check to prevent accessing UI state (LastActivityTime) when the service has been disposed but the timer event still fires.
There was a problem hiding this comment.
Pull request overview
This PR fixes a NullReferenceException that occurs when the UnitOfWorkService's SaveOnIdle timer callback accesses the UI state (LastActivityTime) after the service has been disposed. The fix adds an early IsDisposed check after acquiring the lock but before accessing m_ui, preventing the exception from occurring.
Changes:
- Added IsDisposed check in SaveOnIdle method to prevent accessing m_ui.LastActivityTime when disposed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jtmaxwell3
approved these changes
Jan 30, 2026
Contributor
jtmaxwell3
left a comment
jtmaxwell3
left a comment
There was a problem hiding this comment.
@jtmaxwell3 made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an early IsDisposed check to prevent accessing UI state (LastActivityTime) when the service has been disposed but the timer event still fires.
This change is