Skip to content

This appears to be the only place that is causing the entityid issue #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdijen merged 2 commits into from
Mar 18, 2026
Merged

This appears to be the only place that is causing the entityid issue #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
546c709
Bump the all-actions group with 3 updates (#65)
dependabot[bot] Mar 16, 2026
2581f9a
This appears to be the only place that is causing the entityid issue
monkeyiq Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
matrix:
php-version: ['8.3', '8.4', '8.5']

uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml@v1.11.1
uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml@v1.11.3
with:
php-version: ${{ matrix.php-version }}

Expand All @@ -30,7 +30,7 @@ jobs:
strategy:
fail-fast: false

uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml@v1.11.1
uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml@v1.11.3
with:
enable_eslinter: false
enable_jsonlinter: true
Expand Down Expand Up @@ -276,6 +276,6 @@ jobs:
(needs.unit-tests-linux.result == 'success' && needs.coverage.result == 'skipped')

steps:
- uses: geekyeggo/delete-artifact@v5
- uses: geekyeggo/delete-artifact@v6
with:
name: coverage-data
2 changes: 1 addition & 1 deletion src/MetaLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@
if (count($attributeAuthorities) && !empty($attributeAuthorities[0])) {
$this->addMetadata(
$source['src'],
$attributeAuthorities,
$attributeAuthorities[0],

Check failure on line 202 in src/MetaLoader.php

View workflow job for this annotation

GitHub Actions / Quality control 

Parameter #2 $metadata of method SimpleSAML\Module\metarefresh\MetaLoader::addMetadata() expects array<SAML2\XML\md\AttributeAuthorityDescriptor>|null, SAML2\XML\md\AttributeAuthorityDescriptor given.

Check failure on line 202 in src/MetaLoader.php

View workflow job for this annotation

GitHub Actions / Quality control 

Parameter #2 $metadata of method SimpleSAML\Module\metarefresh\MetaLoader::addMetadata() expects array<SAML2\XML\md\AttributeAuthorityDescriptor>|null, SAML2\XML\md\AttributeAuthorityDescriptor given.
'attributeauthority-remote',
$template,
);
Expand Down
Loading