[REFACTOR]: Move streamApiLow#120
Open
Doominika wants to merge 20 commits intoandroid-stream-api-testingfrom
Open
[REFACTOR]: Move streamApiLow#120Doominika wants to merge 20 commits intoandroid-stream-api-testingfrom
Doominika wants to merge 20 commits intoandroid-stream-api-testingfrom
Conversation
djenczewski
requested changes
Feb 16, 2026
djenczewski
requested changes
Feb 18, 2026
Member
djenczewski
left a comment
djenczewski
left a comment
There was a problem hiding this comment.
- this code doesn't compile
- Can model/events classes be recursively moved to model/stream/events?
|
|
||
| // private native Long init(Connection connection, EventApi eventApi) throws IllegalStateException; | ||
|
|
||
| private static native StreamApiLow create( |
Member
There was a problem hiding this comment.
this is wrong implementation of constructors and create method
djenczewski
approved these changes
Feb 19, 2026
… refactor/move-stream-api-low # Conflicts: # jni-wrappers/privmx-endpoint/src/cpp/parsers/model_native_initializers.cpp # privmx-endpoint-streams/jvm/src/main/java/com/simplito/java/privmx_endpoint/model/VideoTrackInfo.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/model/events/eventTypes/StreamEventType.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/modules/stream/StreamApiLow.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move streamApiLow to privmx-endpoint.