[FEAT]: Upgrade to devel version#121
Open
Doominika wants to merge 16 commits intorefactor/move-stream-api-lowfrom
Open
[FEAT]: Upgrade to devel version#121Doominika wants to merge 16 commits intorefactor/move-stream-api-lowfrom
Doominika wants to merge 16 commits intorefactor/move-stream-api-lowfrom
Conversation
djenczewski
requested changes
Feb 19, 2026
Member
djenczewski
left a comment
djenczewski
left a comment
There was a problem hiding this comment.
This code does not compile
| import jdk.internal.util.ByteArray; | ||
|
|
||
| public class RecordingEncKey { | ||
| public ByteArray id; |
| @@ -0,0 +1,13 @@ | |||
| package com.simplito.java.privmx_endpoint.streams.model; | |||
|
|
|||
| import jdk.internal.util.ByteArray; | |||
Member
There was a problem hiding this comment.
why you import internal package?
| @@ -30,6 +30,7 @@ public class StreamRoom { | |||
| public ContainerPolicy policy; | |||
| public Long statusCode; | |||
| public Long schemaVersion; | |||
| public boolean closed; | |||
Member
There was a problem hiding this comment.
In all Java models we use nullable reference types
| if(streamTrackId != nullptr) result.streamTrackId = jobject2string(ctx, streamTrackId); | ||
|
|
||
| return result; | ||
| } |
Member
There was a problem hiding this comment.
can this be parsed like selector types?
| jobject stream_encryption_mode | ||
| ) { | ||
| JniContextUtils ctx(env); | ||
| if (ctx.nullCheck(connection, "Connection")) { |
Member
There was a problem hiding this comment.
add null check for stream_encryption_mode
Member
There was a problem hiding this comment.
why callResultEndpointApi is commented
Member
There was a problem hiding this comment.
why do you not pass stream_encryption_mode parameter to create method?
| ctx.nullCheck(users, "Users list") || | ||
| ctx.nullCheck(managers, "Managers list") || | ||
| ctx.nullCheck(public_meta, "Public meta") || | ||
| ctx.nullCheck(public_meta, "Public meta") || |
Member
There was a problem hiding this comment.
this probably should be private meta
| ) { | ||
| JniContextUtils ctx(env); | ||
| jobject result; | ||
|
|
Member
There was a problem hiding this comment.
add nullcheck for stream_room_id
…to feat/upgrade-to-devel-version # Conflicts: # jni-wrappers/privmx-endpoint/includes/privmx/endpoint/wrapper/streams/parsers/model_native_initializers.h # jni-wrappers/privmx-endpoint/includes/privmx/endpoint/wrapper/streams/parsers/parser.h # jni-wrappers/privmx-endpoint/src/cpp/modules/StreamApiLow.cpp # jni-wrappers/privmx-endpoint/src/cpp/streams/parsers/model_native_initializers.cpp # jni-wrappers/privmx-endpoint/src/cpp/streams/parsers/parser.cpp # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/model/stream/RecordingEncKey.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/model/stream/StreamEncryptionMode.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/modules/stream/StreamApiLow.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update java wrapper for streamApiLow to devel version from c++ endpoint.