[FEAT]: Add stream events to extra#123
Open
Doominika wants to merge 36 commits intoandroid-stream-api-testingfrom
Open
[FEAT]: Add stream events to extra#123Doominika wants to merge 36 commits intoandroid-stream-api-testingfrom
Doominika wants to merge 36 commits intoandroid-stream-api-testingfrom
Conversation
… feat/add-stream-events # Conflicts: # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/modules/stream/JanusPublisher.java
… feat/add-stream-events # Conflicts: # settings.gradle
…nto new streams directory
Doominika
changed the base branch from
android-stream-api-testing
to
feat/add-stream-events
Doominika
changed the base branch from
feat/add-stream-events
to
android-stream-api-testing
… feat/extra-add-stream-events
… feat/extra-add-stream-events # Conflicts: # jni-wrappers/privmx-endpoint/includes/privmx/endpoint/wrapper/parsers/parser.h # jni-wrappers/privmx-endpoint/includes/privmx/endpoint/wrapper/streams/parsers/model_native_initializers.h # jni-wrappers/privmx-endpoint/includes/privmx/endpoint/wrapper/streams/parsers/parser.h # jni-wrappers/privmx-endpoint/src/cpp/modules/StreamApiLow.cpp # jni-wrappers/privmx-endpoint/src/cpp/parsers/parser.cpp # jni-wrappers/privmx-endpoint/src/cpp/streams/parsers/model_native_initializers.cpp # jni-wrappers/privmx-endpoint/src/cpp/streams/parsers/parser.cpp # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/model/events/NewStreams.java # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/model/events/StreamEventData.java # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/model/events/StreamPublishedEventData.java # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/model/events/StreamRoomDeletedEventData.java # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/model/events/StreamUnpublishedEventData.java # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/model/events/StreamUpdatedEventData.java # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/model/events/StreamsUpdatedData.java # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/model/events/UpdatedStreamData.java # privmx-endpoint-streams/android/src/main/java/com/simplito/java/privmx_endpoint/modules/stream/StreamApiLow.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/model/events/eventTypes/StreamEventType.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/StreamApiLow.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/Key.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/KeyType.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/PublishedStreamData.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/SdpWithTypeModel.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/StreamHandle.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/StreamInfo.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/StreamRoom.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/StreamSubscription.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/StreamTrackInfo.java # privmx-endpoint/src/main/java/com/simplito/java/privmx_endpoint/streams/model/TurnCredentials.java
djenczewski
requested changes
Feb 19, 2026
Member
djenczewski
left a comment
djenczewski
left a comment
There was a problem hiding this comment.
- This code does not compile
- Can all types be moved to the same directory as on "refactor/move-stream-api-low" branch?
| this(enableModule, userPrivateKey, solutionId, bridgeUrl, null); | ||
| } | ||
|
|
||
| public StreamApiLow initializeStreamApi() throws IllegalStateException, PrivmxException { |
Member
There was a problem hiding this comment.
rename to initializeStreamApiLow
|
|
||
| public StreamApiLow initializeStreamApi() throws IllegalStateException, PrivmxException { | ||
| if (streamApiLow == null) { | ||
| streamApiLow = new StreamApiLow(connection, eventApi); |
Member
There was a problem hiding this comment.
if event api is not initialized then this method should throw exception
| this(enableModule, userPrivateKey, solutionId, bridgeUrl, null); | ||
| } | ||
|
|
||
| public StreamApiLow initializeStreamApi() { |
Member
There was a problem hiding this comment.
this method is unnecessary because it is inherited from BasicPrivmxEndpoint
| eventType.eventSelectorId | ||
| ); | ||
| } else { | ||
| throw new IllegalStateException("streamApi is not initialized. Try to initialize it first by calling the initializeStreamApi method."); |
Member
There was a problem hiding this comment.
rename streamApi -> streamApiLow
| break; | ||
| case STREAM: | ||
| if (streamApiLow == null) | ||
| throw new IllegalStateException("streamApi is not initialized"); |
Member
There was a problem hiding this comment.
rename streamApi -> streamApiLow
| break; | ||
| case STREAM: | ||
| if (streamApiLow == null) { | ||
| throw new IllegalStateException("streamApi is not initialized"); |
Member
There was a problem hiding this comment.
rename streamApi -> streamApiLow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for subscribing to StreamApi events and implement function to create StreamApi instance in extra.