Skip to content

Main clone new size #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffrey1330 merged 3 commits into from
Feb 16, 2026
Merged

Main clone new size #878

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9b1281
Ceil new_size to the nearest GiB in snapshot resizing
Hamdy-khader Feb 16, 2026
5e57db0
Ensure new_size is strictly greater than the original size in snapsho…
Hamdy-khader Feb 16, 2026
c8bd072
Merge branch 'main' into main-clone-new-size
Hamdy-khader Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion simplyblock_core/controllers/snapshot_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ def clone(snapshot_id, clone_name, new_size=0, pvc_name=None, pvc_namespace=None

if new_size:
new_size = math.ceil(new_size / (1024 * 1024 * 1024)) * 1024 * 1024 * 1024
if snap.lvol.size >= new_size:
if snap.lvol.size > new_size:
msg = f"New size {new_size} must be higher than the original size {snap.lvol.size}"
logger.error(msg)
return False, msg
Expand Down
Loading