Skip to content

v0.6.17: trigger.dev CI, workers FF#3845

Merged
waleedlatif1 merged 1 commit intomainfrom
staging
Mar 30, 2026
Merged

v0.6.17: trigger.dev CI, workers FF#3845
waleedlatif1 merged 1 commit intomainfrom
staging

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

  • chore(trigger): update @trigger.dev/sdk and @trigger.dev/build to 4.4.3
  • fix(webhooks): execute non-polling webhooks inline when BullMQ is disabled

….3 (#3843)

* chore(trigger): update @trigger.dev/sdk and @trigger.dev/build to 4.4.3

* fix(webhooks): execute non-polling webhooks inline when BullMQ is disabled
@cursor
Copy link
Copy Markdown

cursor bot commented Mar 30, 2026

PR Summary

Medium Risk
Changes webhook execution control flow, which could affect delivery timing and error handling for non-polling webhooks when queueing is misconfigured. Also upgrades @trigger.dev/* dependencies, which may introduce behavior changes in CI/worker tooling.

Overview
Fixes webhook dispatch so non-polling webhooks execute inline whenever BullMQ is disabled, instead of depending on shouldExecuteInline().

Updates @trigger.dev/sdk and @trigger.dev/build to 4.4.3 (lockfile updates included), and removes an unused next/link import from the partners landing page.

Written by Cursor Bugbot for commit 5c47ea5. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 31, 2026 3:38am

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 30, 2026

Greptile Summary

This PR bumps @trigger.dev/sdk and @trigger.dev/build from 4.1.2 to 4.4.3 and fixes a webhook execution bug where non-polling webhooks were silently dropped when trigger.dev was enabled but BullMQ was disabled.

  • Webhook fix (processor.ts): The old guard shouldExecuteInline() returns true only when the async backend type is 'database' (i.e. neither trigger.dev nor BullMQ is enabled). When trigger.dev was active but BullMQ was disabled, shouldExecuteInline() would return false, causing non-polling webhooks to be enqueued into the database inline-backend but never consumed. The fix replaces it with !isBullMQEnabled(), which correctly triggers immediate in-process execution whenever BullMQ is unavailable — regardless of whether trigger.dev is configured.
  • trigger.dev upgrade (package.json, bun.lock): Moves from 4.1.2 → 4.4.3. The new @trigger.dev/core gains OpenTelemetry metrics exporter/SDK and host-metrics dependencies, and drops superjson/copy-anything/is-what from its dependency tree.
  • Unused import cleanup (partners/page.tsx): Removes the Link import that became dead code once the Sim Academy CTAs were commented out pending the Academy launch.

Confidence Score: 5/5

Safe to merge — the webhook fix is logically correct, the trigger.dev upgrade is a straightforward minor-version bump, and all remaining feedback is P2 style.

The core logic change (shouldExecuteInline()!isBullMQEnabled()) correctly addresses the described bug across all four backend combinations. The dependency upgrade is contained to trigger.dev packages with no API-breaking surface relevant to the codebase. The only comment left is a P2 suggestion to add a clarifying comment about the intentional asymmetry between polling and non-polling guards.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/lib/webhooks/processor.ts Bug fix: replaces shouldExecuteInline() (true only in database mode) with !isBullMQEnabled() so non-polling webhooks are executed inline when trigger.dev is enabled but BullMQ is disabled — previously these jobs would be queued in the database backend but never consumed.
apps/sim/app/(landing)/partners/page.tsx Removes unused Link import — the only <Link> usage in this file is commented out (awaiting Sim Academy launch), so the import was dead code.
apps/sim/package.json Bumps @trigger.dev/sdk and @trigger.dev/build from 4.1.2 to 4.4.3; transitive deps gain OpenTelemetry metrics exporters and host-metrics, and drop superjson/copy-anything.
bun.lock Lock file updated to reflect trigger.dev 4.4.3 dependency tree changes; new packages added (@opentelemetry/host-metrics, systeminformation, metrics exporters), removed packages (superjson, copy-anything, is-what).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Incoming Webhook Request] --> B{isPolling?}

    B -- Yes --> C{shouldExecuteInline?\ndatabase mode only}
    C -- No --> D[getJobQueue\ntrigger-dev / bullmq / db]
    D --> E[Enqueue via main backend]
    C -- Yes --> F[Skip — db backend\nhas no queue worker]

    B -- No --> G[getInlineJobQueue\nbullmq OR database\nnever trigger-dev]
    G --> H{isBullMQEnabled?}
    H -- Yes --> I[enqueueWorkspaceDispatch\nBullMQ worker picks up]
    H -- No --> J[jobQueue.enqueue\ndatabase backend]
    J --> K[Execute inline immediately\nnew fix: !isBullMQEnabled]

    style K fill:#22c55e,color:#fff
    style F fill:#f59e0b,color:#fff
Loading

Reviews (1): Last reviewed commit: "chore(trigger): update @trigger.dev/sdk ..." | Re-trigger Greptile

Comment thread apps/sim/lib/webhooks/processor.ts
@waleedlatif1 waleedlatif1 merged commit 73e00f5 into main Mar 30, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant