fix(settings): align general appearance dropdowns to a uniform width#5045
fix(settings): align general appearance dropdowns to a uniform width#5045waleedlatif1 wants to merge 1 commit into
Conversation
Theme/Snap-to-grid (ChipSelect) hugged their content (~90px) while Timezone (ChipCombobox) was pinned to 260px, so the three read as a ragged column. Give all three a shared 240px trigger via fullWidth + a common width wrapper so they align as one column; menus match their triggers. No behavioral change — timezone keeps search, options and handlers are untouched.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Adds Reviewed by Cursor Bugbot for commit 992d552. Configure here. |
Greptile SummaryThis PR fixes a visual alignment issue in the General settings panel where the three appearance dropdowns (Theme, Timezone, Snap-to-grid) rendered at inconsistent widths. All three are now aligned to a shared
Confidence Score: 5/5Safe to merge — purely cosmetic alignment change scoped to a single file with no logic or behavioral modification. The change wraps existing, unmodified chip components in a fixed-width container and passes valid, documented props. Both ChipSelect and Combobox already handle these props correctly. The only functional delta is that the Timezone dropdown menu shrinks from 260px to 240px, which is intentional and consistent with the new unified width. No files require special attention — the single changed file is self-contained and affects only the General settings appearance section. Important Files Changed
Reviews (1): Last reviewed commit: "fix(settings): align general appearance ..." | Re-trigger Greptile |
|
Folding this into #5044 per review — the timezone setting drives the scheduled-tasks calendar, so the dropdown-alignment fix rides along there. Same change cherry-picked onto that branch. |
Summary
ChipSelect) hugged their content (~90px), while Timezone (ChipCombobox) was pinned to260px— so they read as a ragged column.240pxtrigger (viafullWidth+ a common width wrapper constant), so they line up as one column with flush edges. Dropdown menus now match their triggers.Type of Change
Scope / impact
general.tsx. Uses existingChipSelectprops (fullWidth,dropdownWidth) — the sharedChipSelect/ChipComboboxcomponents are not modified, so no other page is affected.Switchtoggles in the panel are untouched.Testing
Tested manually in General settings (light + dark).
Checklist