chore(deps): bump js-yaml to 4.2.0 and nodemailer to 8.0.9#5067
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview There are no application code changes—only manifest and lockfile.
Reviewed by Cursor Bugbot for commit 64dedef. Configure here. |
Greptile SummaryRoutine dependency maintenance bumping
Confidence Score: 4/5Safe to merge; changes are limited to two well-understood dependency bumps with no API surface changes. The nodemailer bump is straightforward. The js-yaml bump introduces a silent type change for underscored numeric literals that is not caught by the existing error-handling, so any YAML files in user data that rely on that syntax would silently change behavior without a visible failure. The two js-yaml callsites — apps/sim/lib/file-parsers/yaml-parser.ts and apps/sim/lib/chunkers/json-yaml-chunker.ts — are worth verifying against representative YAML fixtures to confirm no user data uses underscore-separated numbers. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller
participant yaml_parser as yaml-parser.ts
participant chunker as json-yaml-chunker.ts
participant jsyaml as js-yaml@4.2.0
Caller->>yaml_parser: parseYAML(filePath)
yaml_parser->>jsyaml: yaml.load(content)
Note over jsyaml: New: maxDepth=100, maxMergeSeqLength=20<br/>New: underscored numbers → string (silent)
jsyaml-->>yaml_parser: parsed object (or throws YAMLException)
alt Parse succeeds
yaml_parser-->>Caller: FileParseResult (JSON string)
else Parse throws (depth/merge limits)
yaml_parser-->>Caller: throws "Invalid YAML: ..."
end
Caller->>chunker: JsonYamlChunker.chunk(content)
chunker->>jsyaml: yaml.load(content)
jsyaml-->>chunker: parsed object (or throws)
alt Parse succeeds
chunker-->>Caller: Chunk[]
else Parse throws
chunker-->>Caller: falls back to chunkAsText()
end
Reviews (1): Last reviewed commit: "chore(deps): bump js-yaml to 4.2.0 and n..." | Re-trigger Greptile |
Summary
js-yaml4.1.1 → 4.2.0 inapps/simnodemailer8.0.7 → 8.0.9 inapps/simbun.lock; both resolve cleanly at the top level (unrelated transitive pins ofjs-yaml/nodemailerin other packages are untouched)Backwards compatibility
List-*CRLF-injection advisories). No API changes. Our usage is the standardcreateTransport/sendMailsurface (SMTP, SES, SMTP send route).load()API unchanged. Two edge-case behavioral changes, both safety hardening: new defaultmaxDepth(100) /maxMergeSeqLength(20) loader limits, and underscored numbers (1_000) now parse as strings. Bothload()callsites (yaml-parser.ts,json-yaml-chunker.ts) wrap parsing in try/catch and surface errors gracefully.@types/js-yamland@types/nodemailerunchanged; typecheck clean on all affected files.Type of Change
Testing
bun installresolves cleanlytsc --noEmitshows no errors in affected filesChecklist