fix(providers): allow HTTP for self-hosted vLLM endpoints#5078
Conversation
Pass allowHttp to validateUrlWithDNS so plain-HTTP self-hosted vLLM endpoints are permitted. This only relaxes the protocol check; the private/reserved-IP blocklist and blocked-port checks still apply, so SSRF protection is unchanged.
|
@greptile |
|
@cursor review |
PR SummaryMedium Risk Overview This only relaxes the protocol check; DNS pinning, private/reserved IP blocking, and blocked ports are unchanged. Operator-configured The vLLM provider test now expects the third argument on Reviewed by Cursor Bugbot for commit c20b538. Configure here. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c20b538. Configure here.
Greptile SummaryThis PR is a targeted follow-up to the SSRF hardening in #5077: it passes
Confidence Score: 5/5Safe to merge — the change is a two-line delta that relaxes only the protocol check on user-supplied endpoints while leaving every other SSRF guard intact. The diff is minimal and surgical: { allowHttp: true } is the only runtime change. Reading validateUrlWithDNS and validateExternalUrl confirms that the flag exclusively broadens the accepted protocol set from https: to http:|https: — the private-IP blocklist, blocked-port list, and DNS-pinning path are untouched. The test suite directly asserts the new option is forwarded and confirms that previously-blocked IPs (e.g. 169.254.169.254) remain rejected under the new flag. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(providers): allow HTTP for self-host..." | Re-trigger Greptile |
Summary
{ allowHttp: true }tovalidateUrlWithDNSfor the user-supplied vLLM endpoint so self-hosted vLLM served over plainhttp://on a public host is accepted. Without this it's rejected with "must use https:// protocol".http://169.254.169.254,http://10.0.0.5, etc. remain blocked.Type of Change
Testing
apps/sim/providers/vllm/index.test.tsasserts the endpoint is validated with{ allowHttp: true }; 15/15 pass.tsc --noEmit,biome check,bun run check:api-validationclean.Checklist