[Vengance] Voidfall proc rate is stack-dependent for Vengeance#11154
Open
taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
Open
[Vengance] Voidfall proc rate is stack-dependent for Vengeance#11154taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
Conversation
taherbert
force-pushed
the
dh/voidfall-stack-dependent-proc-rate
branch
from
5886b17 to
2952d3c
Compare
taherbert
changed the title
taherbert
changed the title
taherbert
force-pushed
the
dh/voidfall-stack-dependent-proc-rate
branch
from
2952d3c to
0bd6473
Compare
WCL analysis (55,865 eligible casts) shows voidfall building proc chance decreases with current stack count, rather than being a flat rate from spell data (effectN(3) = 35%): 0 stacks: 39.8% [95% CI: 39.2-40.4%] (p<0.0001 vs 35%) 1 stack: 32.1% [95% CI: 31.4-32.7%] (p<0.0001 vs 35%) 2 stacks: 27.5% [95% CI: 26.8-28.3%] (p<0.0001 vs 35%) Vengeance only — Devourer retains the flat spell data rate pending separate WCL analysis. Defaults exposed as player options for tuning. Local sim impact on Vengeance Annihilator build: -1.14% DPS (66,349 -> 65,591), driven by fewer voidfall meteor procs (37.6 -> 36.5 per fight).
taherbert
force-pushed
the
dh/voidfall-stack-dependent-proc-rate
branch
from
0bd6473 to
29f4d45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectN(3)= 35%)voidfall_proc_chance_{0,1,2}_stacks) for tuningWCL Data
Sim Impact
Local sim on Vengeance Annihilator build (10k iter, te=0.25):