Skip to content

[DH] remove burning blades from voidblade due to bug #11155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToppleTheNun merged 1 commit into from
Mar 12, 2026
Merged

[DH] remove burning blades from voidblade due to bug #11155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion engine/class_modules/sc_demon_hunter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5742,9 +5742,11 @@ struct consume_t : public consume_base_t
}
};

// TOCHECK: Voidblade currently does not trigger burning blades and instead is bugged to trigger for Havoc Felblade

struct voidblade_base_t : public voidrush_trigger_t<hungering_slash_trigger_t<demon_hunter_spell_t>>
{
struct voidblade_damage_t : public shattered_souls_trigger_t<burning_blades_trigger_t<demon_hunter_spell_t>>
struct voidblade_damage_t : public shattered_souls_trigger_t<demon_hunter_spell_t>
{
voidblade_damage_t( util::string_view name, demon_hunter_t* p ) : base_t( name, p, p->spec.voidblade )
{
Expand Down Expand Up @@ -7650,6 +7652,7 @@ struct essence_break_t : public demon_hunter_attack_t

// Felblade =================================================================
// TODO: Real movement stuff.
// TOCHECK: Voidblade currently does not trigger burning blades and instead is bugged to trigger for Havoc Felblade

struct felblade_t : public inertia_trigger_t<demon_hunter_attack_t>
{
Expand Down
Loading