Fix an issue when using classes with similar APIs.#40
Fix an issue when using classes with similar APIs.#40matthid wants to merge 1 commit intoskolima:mainfrom
Conversation
|
Hi @matthid , this looks like a really well prepared PR! Thank you very much. I'll do my best to check it in detail soon. |
|
Hey. I gave this a go, unfortunately it doesn't include the code path for versions without nullable annotation support. I could bump the library to be only |
|
Yes I was a bit confused what was going on there. I thought Nullable is a compiler feature, and you can increase the compiler version to latest https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version and just enable nullable (even for old net framework). This way you should be able to get rid of the compiler directive. I'm not sure if this public-api check you have in place supports that though. |
|
I've dropped the older targets and the path without nullable annotations from the |
When you use Exposed on similar APIs you will run into issues as the DLR will cache requests and fail (or even worse return wrong results)