fix(assistant): get_thread_context calls store.find() for user_message events#1453
fix(assistant): get_thread_context calls store.find() for user_message events#1453
Conversation
…user_message events
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 229 229
Lines 7266 7266
=======================================
Hits 6635 6635
Misses 631 631 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Look good 💯
Left one comment around testing, what do you think about leaving the current tests unchanged and instead add new tests for this case?
| "event_ts": "1726133700.887259", | ||
| "channel_type": "im", | ||
| "assistant_thread": {"XXX": "YYY"}, | ||
| "assistant_thread": {"action_token": "10647138185092.960436384805.afce3599"}, |
There was a problem hiding this comment.
What do you think about leaving the old test cases untouched and adding new ones for this logic?
WilliamBergamin
left a comment
There was a problem hiding this comment.
Nice fix 🚀 🥇
Left 2 non blocking comment let me know what you think
slack_bolt/context/get_thread_context/async_get_thread_context.py
Outdated
Show resolved
Hide resolved
|
@srtaalej any idea when we can expect a fix for this? 🙏 |
Co-authored-by: William Bergamin <wbergamin@salesforce.com>
Co-authored-by: William Bergamin <wbergamin@salesforce.com>
…t pattern in tests
Summary
Fixes
get_thread_context()returningNoneinuser_messagehandlers whenassistant_threadis present in the payload but only contains anaction_token(no context).Closes #1452
Testing
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.