-
Notifications
You must be signed in to change notification settings - Fork 678
feat(web-api): Add support for admin.users.getExpiration #2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
misscoded
wants to merge
4
commits into
main
Choose a base branch
from
add-admin-users-get-expiration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2a5af01
Add support for AdminUsersGetExpirationResponse
misscoded b26055e
Update generated responses from script
misscoded d4211e8
Merge branch 'main' into add-admin-users-get-expiration
misscoded 294512b
Generate response types; import AdminUsersGetExpirationResponse
misscoded File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
packages/web-api/src/types/response/AdminUsersGetExpirationResponse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| ///////////////////////////////////////////////////////////////////////////////////////// | ||
| // // | ||
| // !!! DO NOT EDIT THIS FILE !!! // | ||
| // // | ||
| // This file is auto-generated by scripts/generate-web-api-types.sh in the repository. // | ||
| // Please refer to the script code to learn how to update the source data. // | ||
| // // | ||
| ///////////////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| import type { WebAPICallResult } from '../../WebClient'; | ||
| export type AdminUsersGetExpirationResponse = WebAPICallResult & { | ||
| error?: string; | ||
| needed?: string; | ||
| ok?: boolean; | ||
| provided?: string; | ||
| user?: User; | ||
| }; | ||
|
|
||
| export interface User { | ||
| email?: string; | ||
| expiration_ts?: number; | ||
| id?: string; | ||
| is_restricted?: boolean; | ||
| is_ultra_restricted?: boolean; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/web-api/src/types/response/ChatAppendStreamResponse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/web-api/src/types/response/ChatStartStreamResponse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 9 additions & 17 deletions
26
packages/web-api/src/types/response/ChatStopStreamResponse.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,16 @@ | ||
| import type { Block, KnownBlock } from '@slack/types'; | ||
| ///////////////////////////////////////////////////////////////////////////////////////// | ||
| // // | ||
| // !!! DO NOT EDIT THIS FILE !!! // | ||
| // // | ||
| // This file is auto-generated by scripts/generate-web-api-types.sh in the repository. // | ||
| // Please refer to the script code to learn how to update the source data. // | ||
| // // | ||
| ///////////////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| import type { WebAPICallResult } from '../../WebClient'; | ||
| export type ChatStopStreamResponse = WebAPICallResult & { | ||
| channel?: string; | ||
| error?: string; | ||
| needed?: string; | ||
| ok?: boolean; | ||
| provided?: string; | ||
| ts?: string; | ||
| message?: ChatStopStreamResponseMessage; | ||
| }; | ||
|
|
||
| export interface ChatStopStreamResponseMessage { | ||
| subtype?: string; | ||
| text?: string; | ||
| user?: string; | ||
| streaming_state?: string; | ||
| type?: string; | ||
| ts?: string; | ||
| bot_id?: string; | ||
| thread_ts?: string; | ||
| parent_user_id?: string; | ||
| blocks?: (Block | KnownBlock)[]; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪓 issue(non-blocking): This should be included in the Java generated logs but I'm finding tests aren't covering this for me. Let's keep note to follow up on this - I think using generated types is correct while "message" is optional.
👁️🗨️ ramble: But I wouldn't be opposed to reverting changes of this file if that seems uncertain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zimeg Why would this suddenly go missing?