feat(experiment): add Slack brand theme for charm/huh prompts#351
feat(experiment): add Slack brand theme for charm/huh prompts#351
Conversation
srtaalej
added
enhancement
srtaalej
changed the title
|
|
||
| import ( | ||
| "github.com/charmbracelet/huh" | ||
| "github.com/charmbracelet/lipgloss" |
There was a problem hiding this comment.
💄 praise: So great to see these styles shining!
There was a problem hiding this comment.
📠 question: Would it be better to move this to the internal/style package? I forget if import errors occur, but it might be nice to keep sequences separate from direct I/O operations.
There was a problem hiding this comment.
🗣️ From direct message: This is going to be addressed with #355?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 64.48% 64.45% -0.04%
==========================================
Files 213 214 +1
Lines 17879 18033 +154
==========================================
+ Hits 11530 11623 +93
- Misses 5276 5332 +56
- Partials 1073 1078 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
added
semver:patch
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@srtaalej LGTM! I'm leaving a few comments of changes that'd be nice to include with these updates, but nothing that has to land with this PR.
I'm curious about proper contrast in prompt outputs and left a few screenshots for this. Longterm I'd love to include vhs alongside changes with various setups, but for now let's be diligent to screenshots 🚢
| "github.com/charmbracelet/lipgloss" | ||
| ) | ||
|
|
||
| // Slack brand colors |
There was a problem hiding this comment.
📚 suggestion: Would you have a link to these brandings? It might be nice to include this in comment for ongoing maintenance and curious review-
There was a problem hiding this comment.
that could be nice but its behind okta verification so not visible to public?
There was a problem hiding this comment.
@srtaalej Thanks for checking! Let's use another link with similar recommendation instead:
🔗 https://a.slack-edge.com/4d5bb/marketing/img/media-kit/slack_brand_guidelines_september2020.pdf
| slackAubergine = lipgloss.Color("#4a154b") | ||
| slackBrightAuberg = lipgloss.Color("#611f69") |
There was a problem hiding this comment.
🎨 issue(non-blocking): This purple-esque might not appear well on dark backgrounds! Would using the following AdaptiveColor methods perhaps help toward this?
There was a problem hiding this comment.
👾 ramble: I consider this non-blocking while these are experimental changes, but we should keep watch toward this in ongoing updates before an official release.
There was a problem hiding this comment.
📸 ramble: Similar toward the delete command - the prompt text feels almost hidden to me at the moment:
| Foreground(slackLegalGray). | ||
| Background(lipgloss.Color("#000")) | ||
|
|
||
| // Blurred field styles — subdued version of focused |
There was a problem hiding this comment.
💡 question: I'm not familiar with "blurred" or "focused" styles... Can we expand this comment toward when these appear?
There was a problem hiding this comment.
🗣️ From direct message: This is going to be addressed with #355?
|
🏷️ I marked this as a 🔗 https://docs.slack.dev/tools/slack-cli/reference/experiments |
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
2 participants
Changelog
Added a custom Slack-branded color theme for CLI prompts when using the
charmexperiment flagSummary
This PR adds a custom Slack-branded theme (
ThemeSlack()) for charmbracelet/huh prompts using official brand colors (Aubergine, Blue, Green, Yellow, Red) and wires the theme into all 5 charm form constructors so prompts are styled when-e charmis activeScreen.Recording.2026-02-24.at.1.25.24.PM.mov
Requirements