Add multinode support for aptos service#488
Open
yashnevatia wants to merge 3 commits into
Open
Conversation
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
product-security-plaid-production
Bot
requested review from
dhaidashenko and
vlfig
| // single-finality model (a committed block is final: no reorgs). | ||
| func (c *TOMLConfig) SetMultiNodeDefaults() { | ||
| m := &c.MultiNode.MultiNode | ||
| setDefault(&m.Enabled, true) |
Contributor
There was a problem hiding this comment.
We might want to disable it by default, so that it does not affect CCIP setup.
Not sure if they want to have multinode enabled. We got a pushback on integrating it during initial development.
Contributor
Author
There was a problem hiding this comment.
hi, the way i have used it is that i dont us the multinode client for txm/chainreader/chainwriter.
only for aptos_service.go read methods.
Contributor
There was a problem hiding this comment.
But it'll still be running and producing requests/error/panics in the worst case.
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.