Skip to content

Added vault pending queue stuck threshold #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
russell-stern wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Added vault pending queue stuck threshold #2155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/settings/cresettings/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ flowchart
VaultPluginBatchSizeLimit{{VaultPluginBatchSizeLimit}}:::bound
VaultRequestBatchSizeLimit{{VaultRequestBatchSizeLimit}}:::bound
VaultPendingQueueWriteSizeLimit{{VaultPendingQueueWriteSizeLimit}}:::bound
VaultPendingQueueStuckRoundThreshold{{VaultPendingQueueStuckRoundThreshold}}:::bound
VaultMaxQuerySizeLimit{{VaultMaxQuerySizeLimit}}:::bound
VaultMaxObservationSizeLimit{{VaultMaxObservationSizeLimit}}:::bound
VaultMaxReportsPlusPrecursorSizeLimit{{VaultMaxReportsPlusPrecursorSizeLimit}}:::bound
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"VaultForceEmptyOCRRounds": "false",
"VaultOptimizationsEnabled": "false",
"VaultSignedResponseRequestIDEnabled": "false",
"VaultPendingQueueStuckRoundThreshold": "0",
"GatewayHTTPGlobalRate": "500rps:500",
"GatewayHTTPPerNodeRate": "100rps:100",
"GatewayConfidentialRelayGlobalRate": "50rps:10",
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ VaultBase64EncodingEnabled = 'false'
VaultForceEmptyOCRRounds = 'false'
VaultOptimizationsEnabled = 'false'
VaultSignedResponseRequestIDEnabled = 'false'
VaultPendingQueueStuckRoundThreshold = '0'
GatewayHTTPGlobalRate = '500rps:500'
GatewayHTTPPerNodeRate = '100rps:100'
GatewayConfidentialRelayGlobalRate = '50rps:10'
Expand Down
26 changes: 14 additions & 12 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ var Default = Schema{
VaultForceEmptyOCRRounds: Bool(false),
VaultOptimizationsEnabled: Bool(false),
VaultSignedResponseRequestIDEnabled: Bool(false),
VaultPendingQueueStuckRoundThreshold: Int(0),
GatewayHTTPGlobalRate: Rate(rate.Limit(500), 500),
GatewayHTTPPerNodeRate: Rate(rate.Limit(100), 100),
GatewayConfidentialRelayGlobalRate: Rate(rate.Limit(50), 10),
Expand Down Expand Up @@ -229,12 +230,12 @@ var Default = Schema{
CallLimit: Int(20),
},
HTTPAction: httpAction{
CallLimit: Int(5),
CacheAgeLimit: Duration(10 * time.Minute),
ConnectionTimeout: Duration(10 * time.Second),
RequestSizeLimit: Size(10 * config.KByte),
ResponseSizeLimit: Size(100 * config.KByte),
GatewayProxyDonID: String(""),
CallLimit: Int(5),
CacheAgeLimit: Duration(10 * time.Minute),
ConnectionTimeout: Duration(10 * time.Second),
RequestSizeLimit: Size(10 * config.KByte),
ResponseSizeLimit: Size(100 * config.KByte),
GatewayProxyDonID: String(""),
},
ConfidentialHTTP: confidentialHTTP{
CallLimit: Int(5),
Expand Down Expand Up @@ -271,6 +272,7 @@ type Schema struct {
VaultForceEmptyOCRRounds Setting[bool]
VaultOptimizationsEnabled Setting[bool]
VaultSignedResponseRequestIDEnabled Setting[bool]
VaultPendingQueueStuckRoundThreshold Setting[int] `unit:"{round}"`
GatewayHTTPGlobalRate Setting[config.Rate]
GatewayHTTPPerNodeRate Setting[config.Rate]
GatewayConfidentialRelayGlobalRate Setting[config.Rate]
Expand Down Expand Up @@ -413,12 +415,12 @@ type chainRead struct {
PayloadSizeLimit Setting[config.Size]
}
type httpAction struct {
CallLimit Setting[int] `unit:"{call}"`
CacheAgeLimit Setting[time.Duration]
ConnectionTimeout Setting[time.Duration]
RequestSizeLimit Setting[config.Size]
ResponseSizeLimit Setting[config.Size]
GatewayProxyDonID Setting[string]
CallLimit Setting[int] `unit:"{call}"`
CacheAgeLimit Setting[time.Duration]
ConnectionTimeout Setting[time.Duration]
RequestSizeLimit Setting[config.Size]
ResponseSizeLimit Setting[config.Size]
GatewayProxyDonID Setting[string]
}
type perOrgHTTPAction struct {
MtlsRateLimit Setting[config.Rate]
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func TestSchema_Unmarshal(t *testing.T) {
assert.False(t, cfg.VaultForceEmptyOCRRounds.DefaultValue)
assert.False(t, cfg.VaultOptimizationsEnabled.DefaultValue)
assert.False(t, cfg.VaultSignedResponseRequestIDEnabled.DefaultValue)
assert.Equal(t, 0, cfg.VaultPendingQueueStuckRoundThreshold.DefaultValue)
assert.Equal(t, config.Rate{Limit: rate.Limit(20), Burst: 7}, cfg.GatewayConfidentialRelayGlobalRate.DefaultValue)
assert.Equal(t, config.Rate{Limit: rate.Limit(4), Burst: 2}, cfg.GatewayConfidentialRelayPerNodeRate.DefaultValue)
assert.Equal(t, 48*time.Hour, cfg.PerOrg.ZeroBalancePruningTimeout.DefaultValue)
Expand Down
Loading