fix(ci): require both docker manifests before Slack notify#22877
Merged
Conversation
Partial Slack posts occurred when only core or ccip manifest succeeded. Wait for both docker-core and docker-ccip before announcing images.
Contributor
|
👋 HashWrangler, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
chainchad
approved these changes
Jun 17, 2026
5 tasks
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: LOW
Tightens the slack-notify job gating in the release build/publish workflow so Slack notifications only run when both Docker manifest jobs (docker-core and docker-ccip) succeed, preventing partial announcements when one manifest flakes.
Changes:
- Update
slack-notifyjob-levelif:condition from OR to AND acrossdocker-coreanddocker-ccipresults.
Scrupulous human review areas:
.github/workflows/build-publish.ymljob dependency behavior: confirm the intended behavior when one manifest job isfailure/cancelled/skipped(Slack should not post) and that downstreamtrigger-post-build-publishbehavior remains acceptable whenslack-notifyis skipped (it will pass an emptyslack_thread_ts).
erikburt
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slack-notifyinbuild-publish.ymlso it runs only when bothdocker-coreanddocker-ccipmanifest jobs succeedv2.990.5-beta.0and public chainlink runs)Jira: RANE-4695 (private release improvements). Complements RANE-4683 manifest hardening but is intentionally a separate, chainlink-only change.
Context
Manifest jobs can fail intermittently on
cosign verify("no signatures found") while the other image publishes successfully. The previousifused OR logic, so Slack still posted with only one image line.Test plan
trigger-post-build-publishstill gates ondocker-coreonly (unchanged)Related: smartcontractkit/.github#1577 (cosign verify retry — addresses root flake in shared action)