Skip to content

[PLEX - 3187] - Stellar LOOP Relayer setup + core node cmds#22902

Open
ilija42 wants to merge 20 commits into
developfrom
PLEX-3187-stellar-relayer-setup
Open

[PLEX - 3187] - Stellar LOOP Relayer setup + core node cmds#22902
ilija42 wants to merge 20 commits into
developfrom
PLEX-3187-stellar-relayer-setup

Conversation

@ilija42

@ilija42 ilija42 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Requires

Supports

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 27 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/job/ 2 @smartcontractkit/foundations, @smartcontractkit/core
/core/services/keystore/ 1 @smartcontractkit/foundations
/deployment/ 1 @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/operations-platform, @smartcontractkit/core

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@ilija42 ilija42 force-pushed the PLEX-3187-stellar-relayer-setup branch from 89d004b to 7403d99 Compare June 19, 2026 10:46
@trunk-io

trunk-io Bot commented Jun 19, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@ilija42 ilija42 requested a review from Copilot June 19, 2026 12:10
@ilija42 ilija42 changed the title [PLEX - 3187] - Stellar Relayer setup [PLEX - 3187] - Stellar Relayer setup + core node cmds Jun 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: HIGH — introduces a new relay network (“stellar”) that flows through core relayer initialization, supported-network validation, CLI surface area, and key management APIs.

Changes:

  • Add Stellar as a supported relay network and wire up LOOPP relayer initialization via RelayerFactory + InitStellar.
  • Add Stellar key management across API + CLI (controller, presenter, commands, auth coverage) and ensure test keystores include Stellar.
  • Extend CLI help/test fixtures and health/multichain fixtures for Stellar chains/nodes.

Scrupulous human review recommended (high-impact areas):

  • core/services/chainlink/application.go + relayer_chain_interoperators.go: Stellar relayer initialization and service registration paths.
  • core/services/chainlink/relayer_factory.go: plugin command/env resolution (env.StellarPlugin) and LOOPP relayer instantiation behavior.
  • core/services/relay/relay.go: expanding SupportedNetworks affects multiple validators and tests that iterate supported networks.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
testdata/scripts/nodes/stellar/list/help.txtar Adds CLI help fixture for nodes stellar list.
testdata/scripts/nodes/stellar/help.txtar Adds CLI help fixture for nodes stellar.
testdata/scripts/nodes/help.txtar Adds stellar to nodes top-level help fixture.
testdata/scripts/keys/stellar/help.txtar Adds CLI help fixture for keys stellar.
testdata/scripts/keys/help.txtar Adds stellar to keys top-level help fixture.
testdata/scripts/help-all/help-all.txtar Adds Stellar chains/keys/nodes to help-all fixture output.
testdata/scripts/health/multi-chain-loopp.txtar Adds Stellar chain/node config and expected health checks to multi-chain LOOPP fixture.
testdata/scripts/chains/stellar/list/help.txtar Adds CLI help fixture for chains stellar list.
testdata/scripts/chains/stellar/help.txtar Adds CLI help fixture for chains stellar.
testdata/scripts/chains/help.txtar Adds stellar to chains top-level help fixture.
stellar_smoke.toml Adds a Stellar smoke config example.
plugins/plugins.public.yaml Registers the public Stellar plugin module for loopinstall.
deployment/utils/nodetestutils/node.go Enables OCR2 Stellar keys in node test utils and maps Stellar chain family to OCR2 key type.
core/web/stellar_keys_controller.go Adds Stellar keys API controller wiring.
core/web/stellar_keys_controller_test.go Adds controller tests for Stellar key endpoints.
core/web/router.go Registers /v2/keys/stellar routes via keys controller map.
core/web/presenters/stellar_key.go Adds JSONAPI presenter/resource for Stellar keys.
core/web/auth/auth_test.go Adds RBAC route expectations for Stellar keys/chains/nodes endpoints.
core/services/relay/relay.go Adds NetworkStellar constant and includes it in SupportedNetworks.
core/services/keystore/keystoretest.go Adds Stellar keystore initialization for in-memory keystore tests.
core/services/job/orm.go Extends keystore validation for OCR2 relay stellar.
core/services/job/job_orm_test.go Adds test coverage for Stellar keystore validation.
core/services/chainlink/relayer_factory.go Adds NewStellar relayer constructor that delegates to NewLOOPRelayer.
core/services/chainlink/relayer_chain_interoperators.go Adds InitStellar option to instantiate Stellar relayers and register services.
core/services/chainlink/node_platform.go Adds Stellar submitter key enumeration for Node Platform integration.
core/services/chainlink/application.go Wires Stellar relayer initialization into application startup when enabled by config.
core/internal/cltest/cltest.go Adds DefaultStellarKey test fixture.
core/config/env/env.go Adds StellarPlugin env plugin handle.
core/cmd/stellar_keys_commands.go Adds CLI support for Stellar keys (create/import/export/delete/list rendering).
core/cmd/stellar_keys_commands_test.go Adds CLI tests for Stellar keys commands and presenter output.
core/cmd/app.go Registers keys stellar subcommand.

Comment thread core/services/relay/relay.go
Comment thread stellar_smoke.toml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 5 comments.

Comment thread core/services/chainlink/relayer_chain_interoperators_test.go Outdated
Comment thread core/cmd/stellar_keys_commands_test.go Outdated
Comment thread core/cmd/stellar_keys_commands_test.go
Comment thread core/cmd/stellar_keys_commands_test.go Outdated
Comment thread core/cmd/stellar_keys_commands_test.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 6 comments.

Comment thread deployment/utils/nodetestutils/node.go
Comment thread core/cmd/stellar_keys_commands_test.go
Comment thread core/cmd/stellar_keys_commands_test.go
Comment thread core/cmd/stellar_keys_commands_test.go
Comment thread core/cmd/stellar_keys_commands_test.go
Comment thread core/cmd/stellar_keys_commands_test.go

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated 7 comments.

Comment thread core/cmd/shell_local_test.go Outdated
Comment thread core/services/job/job_orm_test.go
Comment thread core/internal/cltest/cltest.go
Comment thread core/web/stellar_keys_controller.go
Comment thread core/cmd/stellar_keys_commands.go
Comment thread core/web/stellar_keys_controller_test.go
Comment thread core/cmd/stellar_keys_commands_test.go
@ilija42 ilija42 marked this pull request as ready for review June 19, 2026 15:02
@ilija42 ilija42 requested review from a team as code owners June 19, 2026 15:02
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@ilija42 ilija42 changed the title [PLEX - 3187] - Stellar Relayer setup + core node cmds [PLEX - 3187] - Stellar LOOP Relayer setup + core node cmds Jun 19, 2026
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants