Skip to content

Fix semaphore usage in don2don server req#22904

Draft
dhaidashenko wants to merge 1 commit into
developfrom
fix/server_req
Draft

Fix semaphore usage in don2don server req#22904
dhaidashenko wants to merge 1 commit into
developfrom
fix/server_req

Conversation

@dhaidashenko

@dhaidashenko dhaidashenko commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Ensure that we lock the semaphore only once the capability execution is ready to occur.

Previously, multiple goroutines could acquire the semaphore lock and then wait for the same request to execute.
Thus, a single request occupied multiple semaphore slots for an extended period.

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Jun 19, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
TestWriteReportExcludeSignaturesHasher_Hash_Stellar The test named TestWriteReportExcludeSignaturesHasher_Hash_Stellar failed during execution. Logs ↗︎
Test_RemoteExecutableCapability_ExecutionNotBlockedBySlowCapabilityExecution_AllAtOnce The test failed without a specific error message, likely due to a timeout or missing expected behavior. Logs ↗︎
TestTestMetadataRegistry_LocalNode_UsesConfiguredWorkflowDONF The test failed during execution without providing specific error details. Logs ↗︎
TestDonNotifier_WaitForDon The test 'TestDonNotifier_WaitForDon' failed without providing specific error details. Logs ↗︎

... and 3 more

View Full Report ↗︎Docs

@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant