docs: clarify step 7 server delivery code snippets#540
Open
vipin8797 wants to merge 1 commit into
Open
Conversation
Splits the final combined code block into distinct CommonJS and ES Modules tabs for better clarity. Highlights the newly added �sync keyword for io.on and socket.on. Fixes socketio#512.
|
@vipin8797 is attempting to deploy a commit to the SocketIO Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR resolves an issue with the "Step #7 Server delivery" tutorial where the final code snippet was presented as a single combined block without differentiating between CommonJS and ES Modules.
Users using CommonJS encountered a
SyntaxError: Unexpected reserved worddue to the top-levelawaitbecause the implicitasync function main()wrapper wasn't shown in the snippet. Additionally, theasynckeyword was added silently without any highlighting, causing confusion.Changes Made:
<Tabs>withcjsandmjsvariants, matching the style established in previous tutorial steps.// highlight-next-lineimmediately before theio.on('connection', async (socket)andsocket.on('chat message', async (msg)lines so students are aware of the newly introducedasynckeywords.Fixes #512