Add SIGTERM regression test for Hybrid fork interrupt handling#60
Merged
Conversation
SIGINT and SIGTERM are intentionally equivalent: both are trapped in the fork and converted into Interrupt (see Forked::Child.fork), so a single signal of either kind must drain the inner threads and exit rather than respawning them (issue #58). Refactors the existing single-SIGINT test into a shared helper and exercises both :INT and :TERM, locking in the documented equivalence.
ioquatix
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #58 / #59.
SIGINTandSIGTERMare intentionally treated as equivalent in this library: both are trapped in each fork and converted into the sameInterruptexception (Forked::Child.fork):The fix in #59 (
Generic#interruptsets@stopping = true) therefore covers a singleSIGTERMto aHybridfork as well — it must drain the inner threads and exit, rather than respawning them forever (the inner container runs withrestart: true, the default forasync-servicemanaged services).This PR adds a regression test for the
SIGTERMpath so the equivalence is locked in and can't silently regress.Changes
SIGINTtest into a shared helper.:INTand:TERMvia the helper.Verification
@stopping = trueis reverted inGeneric#interrupt, confirming they are meaningful regression tests rather than false passes.