Add support for Process.fork within an active scheduler.#437
Merged
Conversation
Contributor
Author
|
@noteflakes I experimented with this too. I think having a proper hook would be a good idea but it's sufficient to use |
ggmichaelgo
reviewed
Nov 28, 2025
ggmichaelgo
approved these changes
Nov 28, 2025
samuel-williams-shopify
force-pushed
the
process_fork
branch
4 times, most recently
from
0ef6611 to
81f5512
Compare
ioquatix
force-pushed
the
process_fork
branch
3 times, most recently
from
de57cf7 to
69653c6
Compare
ioquatix
force-pushed
the
process_fork
branch
from
69653c6 to
6834143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Process.forkwithin a scheduler had undefined behaviour. However, after considering it, it looks like we can correctly support it, if we shut down the scheduler in the child process correctly.Types of Changes
Contribution