Skip to content

Comments

Allow static methods in dynamic values#137

Merged
HypeMC merged 1 commit intosofascore:2.xfrom
HypeMC:support-static-methods-in-dynamicvalues
Feb 25, 2026
Merged

Allow static methods in dynamic values#137
HypeMC merged 1 commit intosofascore:2.xfrom
HypeMC:support-static-methods-in-dynamicvalues

Conversation

@HypeMC
Copy link
Member

@HypeMC HypeMC commented Feb 22, 2026

Summary 📝

Allows using static methods as DynamicValues providers:

#[PurgeOn(SomeEntity::class,
    routeParams: [
        'param' => new DynamicValues(provider: [MyClass::class, 'staticMethod']),
    ],
)]

Checklist ✅

  • Tests updated 🐛
  • Docs updated 📚
  • Changelog updated 📋
  • Breaking change ⚠️

@HypeMC HypeMC requested a review from Brajk19 February 22, 2026 00:16
@HypeMC HypeMC self-assigned this Feb 22, 2026
@HypeMC HypeMC requested a review from lskupnjak February 22, 2026 00:16
@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.32%. Comparing base (f514388) to head (e727c24).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #137      +/-   ##
============================================
+ Coverage     97.30%   97.32%   +0.02%     
- Complexity      506      512       +6     
============================================
  Files            69       69              
  Lines          1408     1421      +13     
============================================
+ Hits           1370     1383      +13     
  Misses           38       38              
Flag Coverage Δ
8.1 97.32% <100.00%> (+0.02%) ⬆️
8.2 97.25% <100.00%> (+0.02%) ⬆️
8.3 97.04% <100.00%> (+0.02%) ⬆️
8.4 97.04% <100.00%> (+0.02%) ⬆️
8.5 97.04% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HypeMC HypeMC force-pushed the support-static-methods-in-dynamicvalues branch 5 times, most recently from bd86c05 to 723bd90 Compare February 24, 2026 00:00
@HypeMC HypeMC force-pushed the support-static-methods-in-dynamicvalues branch from 723bd90 to e727c24 Compare February 24, 2026 13:40
@HypeMC HypeMC merged commit fe08b34 into sofascore:2.x Feb 25, 2026
27 checks passed
@HypeMC HypeMC deleted the support-static-methods-in-dynamicvalues branch February 25, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants