Skip to content

fix(ios): avoid WorkletsModule.h import that breaks worklets-enabled builds #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Traviskn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): avoid WorkletsModule.h import that breaks worklets-enabled builds #1102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-native-audio-api/RNAudioAPI.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,11 @@ Pod::Spec.new do |s|
"\"$(PODS_TARGET_SRCROOT)/#{external_dir_relative}/include/vorbis\""
])
.concat($RN_AUDIO_API_FFMPEG_DISABLED ? [] : ["\"$(PODS_TARGET_SRCROOT)/#{external_dir_relative}/include_ffmpeg\""])
.concat(worklets_enabled ? ['"$(PODS_ROOT)/Headers/Public/RNWorklets"'] : [])
.concat(worklets_enabled ? [
'"$(PODS_ROOT)/Headers/Public/RNWorklets"',
'"$(PODS_ROOT)/Headers/Private/ReactCodegen"',
'"$(PODS_ROOT)/../build/generated/ios/ReactCodegen"',
] : [])
.join(' '),
"CLANG_CXX_LANGUAGE_STANDARD" => "c++20",
"GCC_PREPROCESSOR_DEFINITIONS" => '$(inherited) HAVE_ACCELERATE=1',
Expand All @@ -120,6 +124,8 @@ Pod::Spec.new do |s|
]
.concat(worklets_enabled ? [
'"$(PODS_ROOT)/Headers/Public/RNWorklets"',
'"$(PODS_ROOT)/Headers/Private/ReactCodegen"',
'"$(PODS_ROOT)/../build/generated/ios/ReactCodegen"',
"\"$(PODS_ROOT)/#{$audio_api_config[:dynamic_frameworks_worklets_dir]}/apple\"",
"\"$(PODS_ROOT)/#{$audio_api_config[:dynamic_frameworks_worklets_dir]}/Common/cpp\""
] : [])
Expand Down
8 changes: 7 additions & 1 deletion packages/react-native-audio-api/ios/audioapi/ios/AudioAPIModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@

#import <audioapi/core/utils/worklets/SafeIncludes.h>
#if RN_AUDIO_API_ENABLE_WORKLETS
#import <worklets/apple/WorkletsModule.h>
// Forward-declare the single method used from WorkletsModule instead of importing
// <worklets/apple/WorkletsModule.h>, which transitively includes the codegen-generated
// <rnworklets/rnworklets.h> that is not visible to this compile unit in all build setups
// (e.g. prebuilt RNWorklets in EAS builds).
@interface WorkletsModule : NSObject
- (std::shared_ptr<worklets::WorkletsModuleProxy>)getWorkletsModuleProxy;
@end
#endif
#ifdef RCT_NEW_ARCH_ENABLED
#import <React/RCTCallInvoker.h>
Expand Down
Loading