Skip to content

fix(android): use 'category' key instead of 'type'#1106

Open
zvonimirr wants to merge 1 commit into
software-mansion:mainfrom
zvonimirr:android-category
Open

fix(android): use 'category' key instead of 'type'#1106
zvonimirr wants to merge 1 commit into
software-mansion:mainfrom
zvonimirr:android-category

Conversation

@zvonimirr

Copy link
Copy Markdown

Closes #

When enumerating devices on Android the category field is empty, this is due to the fact that we use "type" instead of "category"

⚠️ Breaking changes ⚠️

Introduced changes

  • Changed the key in the device info map from "type" to "category" when reporting both input and output audio devices.
  • Renamed the function parseDeviceType to parseDeviceCategory to match the new terminology.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant