Open
Conversation
mkopcins
approved these changes
Feb 11, 2026
chmjkb
reviewed
Mar 23, 2026
Collaborator
chmjkb
left a comment
chmjkb
left a comment
There was a problem hiding this comment.
Other than that I think it's good
Comment on lines
56
to
58
| if (!isValidTypedArray) { | ||
| throw jsi::JSError(runtime, "Value must be a TypedArray"); | ||
| throw jsi::JSError(runtime, "Value must be an ArrayBuffer or TypedArray"); | ||
| } |
Collaborator
There was a problem hiding this comment.
I'm wondering if we should throw the rnexecutorch error here
Comment on lines
-340
to
-346
| inline jsi::Value getJsiValue(const std::vector<char> &vec, | ||
| jsi::Runtime &runtime) { | ||
| jsi::Array array(runtime, vec.size()); | ||
| for (size_t i = 0; i < vec.size(); i++) { | ||
| array.setValueAtIndex(runtime, i, jsi::Value(vec[i])); | ||
| } | ||
| return {runtime, array}; |
Collaborator
There was a problem hiding this comment.
Are we deleting this because it's not used? Or there's some other reason
msluszniak
commented
Mar 23, 2026
| jsi::String::createFromUtf8(runtime, vec[i])); | ||
| } | ||
| return {runtime, array}; | ||
| inline jsi::Value getJsiValue(int val, jsi::Runtime & /*runtime*/) { |
Member
Author
There was a problem hiding this comment.
TODO: Same for the rest of functions
Suggested change
| inline jsi::Value getJsiValue(int val, jsi::Runtime & /*runtime*/) { | |
| inline jsi::Value getJsiValue(int32_t val, jsi::Runtime & /*runtime*/) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Closes #785
Checklist
Additional notes