Skip to content

chore: add an error log when adapter is missing#994

Merged
msluszniak merged 2 commits intomainfrom
@chmjkb/log-on-missing-fetcher-adapter
Mar 23, 2026
Merged

chore: add an error log when adapter is missing#994
msluszniak merged 2 commits intomainfrom
@chmjkb/log-on-missing-fetcher-adapter

Conversation

@chmjkb
Copy link
Collaborator

@chmjkb chmjkb commented Mar 23, 2026

Description

This PR introduces more discoverability to a potential common pitfall of user not calling initExecutorch, before using the resource fetcher.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@chmjkb chmjkb self-assigned this Mar 23, 2026
@chmjkb chmjkb added the chore PRs that are chores label Mar 23, 2026
@chmjkb chmjkb force-pushed the @chmjkb/log-on-missing-fetcher-adapter branch from 8e22713 to 7afb156 Compare March 23, 2026 14:11
@msluszniak msluszniak merged commit 3b26473 into main Mar 23, 2026
4 checks passed
@msluszniak msluszniak deleted the @chmjkb/log-on-missing-fetcher-adapter branch March 23, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore PRs that are chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants