NH-102271 Add image APM version bump to 'Create Release PR' action#531
Merged
tammy-baylis-swi merged 3 commits intomainfrom Feb 19, 2025
Merged
NH-102271 Add image APM version bump to 'Create Release PR' action#531tammy-baylis-swi merged 3 commits intomainfrom
tammy-baylis-swi merged 3 commits intomainfrom
Conversation
cheempz
approved these changes
Feb 19, 2025
Contributor
cheempz
left a comment
cheempz
left a comment
There was a problem hiding this comment.
LGTM, thanks for that example PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the "Create Release PR" workflow to also bump the APM Python version in image/requirements-nodeps.txt. This is so "Publish APM Python Auto-Instrumentation" can be run, manually and minutes after PyPI updates are picked up by GH, after PyPI publish is complete but with less to remember.
This also fixes the existing version.py update logic that was unnecessarily adding newlines.
Example test PR: #533