NH-113981 Remove unnecessary try-except around custom distro load_instrumentor call#660
Merged
tammy-baylis-swi merged 2 commits intomainfrom Jul 3, 2025
Merged
Conversation
cheempz
approved these changes
Jul 3, 2025
Contributor
cheempz
left a comment
cheempz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR description @tammy-baylis-swi!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unnecessary try-except around custom distro
load_instrumentorcall, which is currently resulting in more scaryerrorlogs than necessary even though auto-instrumentation still works. See ticket for example logging.Possible exceptions that would happen, such as the framework-to-instrument being absent, are handled by upstream's _load_instrumentors at call to
opentelemetry-instrument. This is why upstream default distro (used by both default AWS layer and k8s image) does not do a try-except-log either.There is a test version bump because I did a Lambda staging publish to test, and this fixes the too-much-logs issue.