Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
| useAssets_(() => renderAsset(asset, nonce)); | ||
| entity.ssrIdx = ssrRequestAssets.length - 1; | ||
| useAssets_(() => renderAsset(asset, nonce) as any); | ||
| if (ssrRequestAssets) { |
There was a problem hiding this comment.
im not sure if these changes are correct or needed
| // used on native HTML elements during SSR transformation. The previous | ||
| // implementation used JSX (<style {...props.attrs}> etc.) which triggered the | ||
| // bug. Instead we build the HTML strings directly — these assets are only | ||
| // ever rendered during SSR so reactive JSX is unnecessary. |
There was a problem hiding this comment.
these changes are probably unneeded
There was a problem hiding this comment.
seems that they are needed in some capacity
|
We can probably use |
|
needs rebasing |
2 participants
PR Checklist
Seeing what It take to update SolidStart to use Solid 2.0 beta. The bare example works with no router.
These are the following outstanding issues