Explicitly use the class name that is being deprecated#4838
Closed
elia wants to merge 3 commits into
Closed
Conversation
github-actions
Bot
added
the
changelog:solidus_core
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #4838 +/- ##
=======================================
Coverage 86.16% 86.16%
=======================================
Files 578 578
Lines 14664 14664
=======================================
Hits 12635 12635
Misses 2029 2029
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jarednorman
approved these changes
Jan 6, 2023
adammathys
approved these changes
Jan 6, 2023
waiting-for-dev
approved these changes
Jan 9, 2023
The message is otherwise hard to understand.
elia
force-pushed
the
elia/improve-deprecation-message
branch
from
68acd75 to
accab6d
Compare
Appeasing Rubocop in the process.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The message is otherwise hard to understand.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):- [ ] I have added automated tests to cover my changes. - [ ] I have attached screenshots to demo visual changes. - [ ] I have opened a PR to update the [guides](https://github.com/solidusio/edgeguides). - [ ] I have updated the README to account for my changes.