This repository was archived by the owner on Jun 3, 2020. It is now read-only.
Rewrite image links if they are downloaded.#74
Open
jkukul wants to merge 8 commits intosome-programs:masterfrom
jkukul:master
Open
Rewrite image links if they are downloaded.#74jkukul wants to merge 8 commits intosome-programs:masterfrom jkukul:master
jkukul wants to merge 8 commits intosome-programs:masterfrom
jkukul:master
Conversation
When download_images option is disabled there's no other need to parse html, so I'm suggesting to optimise and only parse html when it's actually needed.
Instead of doing it repeatedly for every loop iteration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #42.
642bfa8 contains the additional logic.
Other commits are either preparatory refactors or code style improvements.