feat(chore): support retrieval of invoice PDF download URLs#28
Open
Sourav-kashyap wants to merge 7 commits into
Open
feat(chore): support retrieval of invoice PDF download URLs#28Sourav-kashyap wants to merge 7 commits into
Sourav-kashyap wants to merge 7 commits into
Conversation
support retrieval of invoice PDF download URLs GH-27
Sourav-kashyap
force-pushed
the
GH-27
branch
2 times, most recently
from
2b285cc to
d9447ee
Compare
… support add invoice payment details and payment intent retrieval support GH-27
Tyagi-Sunny
reviewed
May 8, 2026
Tyagi-Sunny
reviewed
May 8, 2026
Tyagi-Sunny
approved these changes
May 12, 2026
yeshamavani
requested changes
May 13, 2026
| * - canceled | ||
| * - succeeded | ||
| */ | ||
| status: string; |
Comment on lines
+281
to
+292
| /** Card brand: visa, mastercard, amex, etc. */ | ||
| brand: string; | ||
| /** Last 4 digits */ | ||
| last4: string; | ||
| /** Expiration month */ | ||
| expMonth: number; | ||
| /** Expiration year */ | ||
| expYear: number; | ||
| /** Funding type: credit, debit, prepaid, unknown */ | ||
| funding: string; | ||
| /** Country code */ | ||
| country?: string; |
Collaborator
There was a problem hiding this comment.
define these separately
Comment on lines
+298
to
+305
| bankName: string; | ||
| /** Last 4 digits */ | ||
| last4: string; | ||
| /** Routing number */ | ||
| routingNumber?: string; | ||
| /** Account type: checking, savings */ | ||
| accountType?: string; | ||
| }; |
|
|
||
| // Payment method default values | ||
| const DEFAULT_EXPIRY_MONTH = 12; | ||
| const DEFAULT_EXPIRY_YEAR = 2025; |
Collaborator
There was a problem hiding this comment.
how is default 2025 valid ?
take these from config user will pass via env
|
|
||
| // Payment method default values | ||
| const DEFAULT_EXPIRY_MONTH = 12; | ||
| const DEFAULT_EXPIRY_YEAR = 2025; |
SonarQube reviewer guideSummary: Add invoice PDF retrieval, payment details, and payment intent tracking for both Stripe and ChargeBee providers, with comprehensive adapters and type definitions. Review Focus:
Start review at:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change introduces enhancements for invoice data access and payment-related operations.
Changes
Using Stripe:
Stripe.mov
Using Chargebee:
Chargebee.mov