Conversation
Remove the github.com/cockroachdb/errors dependency and replace all usages with standard library equivalents: - errors.New (stdlib) - fmt.Errorf with %w for wrapping - errors.Join for combining errors This also removes ~6 transitive dependencies (cockroachdb/logtags, cockroachdb/redact, getsentry/sentry-go, gogo/protobuf, pkg/errors). Fixes a pre-existing bug in readVarint where errors.Newf was missing the loop index argument for the %d format verb.
The slices package has been in stdlib since Go 1.21. This removes the golang.org/x/exp dependency from bindings/go/scip/go.mod.
Replace autogold snapshot assertions with require.Equal in source_file_test.go and position_test.go. This removes autogold/v2 and its 6 transitive indirect deps (valast, lockfile, x/mod, x/sync, x/tools, gofumpt).
jupblb
force-pushed
the
michal/go-bindings-deps
branch
from
644161b to
63e93bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this library is used in other projects it should propagate as few transitive dependencies as possible.