Skip to content

Fix GCC macOS downstream builds#2530

Merged
jviotti merged 1 commit into
mainfrom
fix-gcc-2
Jun 19, 2026
Merged

Fix GCC macOS downstream builds#2530
jviotti merged 1 commit into
mainfrom
fix-gcc-2

Conversation

@jviotti

@jviotti jviotti commented Jun 19, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@augmentcode

augmentcode Bot commented Jun 19, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR fixes downstream GCC builds on macOS/aarch64 by avoiding problematic ARM ACLE headers while preserving the hardware-accelerated CRC32 implementation.

Changes:

  • Removes the dependency on <arm_acle.h> for the CRC32 hardware path
  • Adds small wrapper helpers that call CRC32 instructions via compiler builtins (Clang vs GCC)
  • Updates the CRC32 update loop to use the new builtin wrappers for 64-bit chunks and tail bytes

Technical Notes: Keeps the existing ISA feature gating (aarch64 + __ARM_FEATURE_CRC32) to avoid SIGILL on CPUs without the CRC32 extension.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 615974e Previous: 768e61b Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 1.5754480657101784 ns/iter 1.694457504640136 ns/iter 0.93
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.6172435153732134 ns/iter 1.7080853379137182 ns/iter 0.95
Regex_Period_Asterisk 1.59622997437536 ns/iter 1.6455650517297065 ns/iter 0.97
Regex_Group_Period_Asterisk_Group 1.5705545262486802 ns/iter 1.684263224848592 ns/iter 0.93
Regex_Period_Plus 1.920577796281542 ns/iter 2.1237289332231777 ns/iter 0.90
Regex_Period 1.886768598353451 ns/iter 2.079320067373334 ns/iter 0.91
Regex_Caret_Period_Plus_Dollar 1.8826772683811253 ns/iter 2.006561459920716 ns/iter 0.94
Regex_Caret_Group_Period_Plus_Group_Dollar 1.8833039328070345 ns/iter 1.9850556118533083 ns/iter 0.95
Regex_Caret_Period_Asterisk_Dollar 1.5687679789776041 ns/iter 1.629772924812744 ns/iter 0.96
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.5716524128715261 ns/iter 1.5793232230047336 ns/iter 1.00
Regex_Caret_X_Hyphen 5.659258515699469 ns/iter 5.653900829093252 ns/iter 1.00
Regex_Period_Md_Dollar 15.777672603912587 ns/iter 16.155438492155216 ns/iter 0.98
Regex_Caret_Slash_Period_Asterisk 4.161601048280152 ns/iter 4.137394980167578 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 2.016447849297703 ns/iter 1.909746732839834 ns/iter 1.06
Regex_Nested_Backtrack 23.136289405237797 ns/iter 25.71068243361038 ns/iter 0.90
JSON_Array_Of_Objects_Unique 316.2111951588913 ns/iter 322.539757521576 ns/iter 0.98
JSON_Parse_1 3558.058508453812 ns/iter 3618.563810324513 ns/iter 0.98
JSON_Parse_Real 4857.173861915769 ns/iter 5218.263162048657 ns/iter 0.93
JSON_Parse_Decimal 5176.017577343818 ns/iter 5668.404468206457 ns/iter 0.91
JSON_Parse_Schema_ISO_Language 3044219.909091253 ns/iter 2925362.4156862157 ns/iter 1.04
JSON_Parse_Integer 2798.4105711277725 ns/iter 3217.9795821903617 ns/iter 0.87
JSON_Parse_String_NonSSO_Plain 3266.905135694433 ns/iter 3784.723315573291 ns/iter 0.86
JSON_Parse_String_SSO_Plain 1650.5974434071245 ns/iter 1830.3247569604744 ns/iter 0.90
JSON_Parse_String_Escape_Heavy 15257.758438568266 ns/iter 17330.9517830246 ns/iter 0.88
JSON_Parse_Object_Short_Keys 5018.853749998016 ns/iter 6319.914480737652 ns/iter 0.79
JSON_Parse_Object_Scalar_Properties 2561.6628873720197 ns/iter 3732.0486898388904 ns/iter 0.69
JSON_Parse_Object_Array_Properties 3253.1604493177283 ns/iter 4628.868519419817 ns/iter 0.70
JSON_Parse_Object_Object_Properties 3253.667153880208 ns/iter 4161.2588871136 ns/iter 0.78
JSON_Parse_Nested_Containers 25703.820639844795 ns/iter 32716.259934216905 ns/iter 0.79
JSON_From_String_Copy 22.70853759112508 ns/iter 33.144020317125566 ns/iter 0.69
JSON_From_String_Temporary 18.07882634299739 ns/iter 27.319788642560905 ns/iter 0.66
JSON_Number_To_Double 30.828366154910135 ns/iter 44.32104676773909 ns/iter 0.70
JSON_Object_At_Last_Key/8 3.525806122442512 ns/iter 5.009545424756264 ns/iter 0.70
JSON_Object_At_Last_Key/32 11.000262980247806 ns/iter 14.216088713440126 ns/iter 0.77
JSON_Object_At_Last_Key/128 50.40698415562571 ns/iter 58.82315363191911 ns/iter 0.86
JSON_Object_At_Last_Key/512 175.983897067039 ns/iter 214.02944138354408 ns/iter 0.82
JSON_Fast_Hash_Helm_Chart_Lock 57.51948419131068 ns/iter 79.90071220165878 ns/iter 0.72
JSON_Equality_Helm_Chart_Lock 124.17807698564006 ns/iter 183.52287781949698 ns/iter 0.68
JSON_Divisible_By_Decimal 166.60522874919465 ns/iter 258.71676104045633 ns/iter 0.64
JSON_String_Equal/10 6.298516543852746 ns/iter 7.84565600246703 ns/iter 0.80
JSON_String_Equal/100 6.024446831716781 ns/iter 7.2795420522072565 ns/iter 0.83
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7369922955010603 ns/iter 0.8362373880871047 ns/iter 0.88
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.108513345036234 ns/iter 3.8944227655964516 ns/iter 0.80
JSON_String_Fast_Hash/10 2.20430408619705 ns/iter 2.76846507413839 ns/iter 0.80
JSON_String_Fast_Hash/100 1.8854253300062793 ns/iter 2.2406394198888746 ns/iter 0.84
JSON_String_Key_Hash/10 1.2603851378398254 ns/iter 1.5446359770709943 ns/iter 0.82
JSON_String_Key_Hash/100 1.9981370396256306 ns/iter 2.6526386055415587 ns/iter 0.75
JSON_Object_Defines_Miss_Same_Length 2.209781079648597 ns/iter 2.405679856565861 ns/iter 0.92
JSON_Object_Defines_Miss_Too_Small 2.283118768972114 ns/iter 3.0478129540152192 ns/iter 0.75
JSON_Object_Defines_Miss_Too_Large 2.2348848750773134 ns/iter 3.054468517508014 ns/iter 0.73
Pointer_Object_Traverse 12.870948906556508 ns/iter 15.378522203639575 ns/iter 0.84
Pointer_Object_Try_Traverse 23.111522323881324 ns/iter 24.35204617804943 ns/iter 0.95
Pointer_Push_Back_Pointer_To_Weak_Pointer 152.85664633410875 ns/iter 167.24707509810577 ns/iter 0.91
Pointer_Walker_Schema_ISO_Language 1960475.5586592369 ns/iter 2752351.4201388047 ns/iter 0.71
Pointer_Maybe_Tracked_Deeply_Nested/0 781408.1986218526 ns/iter 924785.9135285927 ns/iter 0.84
Pointer_Maybe_Tracked_Deeply_Nested/1 1078143.67868322 ns/iter 1349836.5878907847 ns/iter 0.80
Pointer_Position_Tracker_Get_Deeply_Nested 303.8267065436832 ns/iter 359.34442075244056 ns/iter 0.85
URITemplateRouter_Create 21383.96647020705 ns/iter 23328.95869190808 ns/iter 0.92
URITemplateRouter_Match 151.8900742618112 ns/iter 187.6226914032726 ns/iter 0.81
URITemplateRouter_Match_BasePath 181.75405825417658 ns/iter 198.89682848006157 ns/iter 0.91
URITemplateRouterView_Restore 8790.166913615107 ns/iter 11393.902000799866 ns/iter 0.77
URITemplateRouterView_Match 123.63267856278904 ns/iter 145.19024083296532 ns/iter 0.85
URITemplateRouterView_Match_BasePath 137.7648755901591 ns/iter 152.6971845821291 ns/iter 0.90
URITemplateRouterView_Arguments 375.503333160426 ns/iter 410.27676483121894 ns/iter 0.92
JSONL_Parse_Large 11542590.836061059 ns/iter 12427520.4081632 ns/iter 0.93
JSONL_Parse_Large_GZIP 12398706.857140953 ns/iter 13086895.43396187 ns/iter 0.95
HTML_Build_Table_100000 60282185.63638306 ns/iter 60579507.54545386 ns/iter 1.00
HTML_Render_Table_100000 2366297.48571489 ns/iter 2773654.7927460205 ns/iter 0.85
GZIP_Compress_ISO_Language_Set_3_Locations 24688028.28570915 ns/iter 25209450.89285728 ns/iter 0.98
GZIP_Decompress_ISO_Language_Set_3_Locations 4752110.553332993 ns/iter 5147873.148148055 ns/iter 0.92
GZIP_Compress_ISO_Language_Set_3_Schema 1408881.8614457424 ns/iter 1439433.0448065435 ns/iter 0.98
GZIP_Decompress_ISO_Language_Set_3_Schema 260466.2060462333 ns/iter 263110.85871212167 ns/iter 0.99
JOSE_VerifySignature_RS256 20779.741704365024 ns/iter 21621.368295032175 ns/iter 0.96
JOSE_VerifySignature_ES512 905194.1378413498 ns/iter 929229.7323369471 ns/iter 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 615974e Previous: 768e61b Ratio
JOSE_VerifySignature_RS256 24700.139539808933 ns/iter 24606.50920664507 ns/iter 1.00
JOSE_VerifySignature_ES512 643791.7754354539 ns/iter 641233.1420715268 ns/iter 1.00
GZIP_Compress_ISO_Language_Set_3_Locations 39331646.38889113 ns/iter 39337323.16666768 ns/iter 1.00
GZIP_Decompress_ISO_Language_Set_3_Locations 4052223.8497109185 ns/iter 4066514.540697167 ns/iter 1.00
GZIP_Compress_ISO_Language_Set_3_Schema 2284272.4169382527 ns/iter 2282638.537459067 ns/iter 1.00
GZIP_Decompress_ISO_Language_Set_3_Schema 298590.7413333027 ns/iter 276399.65542904945 ns/iter 1.08
HTML_Build_Table_100000 70326750.79999535 ns/iter 70664838.79999623 ns/iter 1.00
HTML_Render_Table_100000 1963209.9441342973 ns/iter 2139506.3940298683 ns/iter 0.92
JSONL_Parse_Large 12439434.46428578 ns/iter 12458006.41071477 ns/iter 1.00
JSONL_Parse_Large_GZIP 14091471.780000119 ns/iter 13979592.05999996 ns/iter 1.01
URITemplateRouter_Create 29921.044548303053 ns/iter 29519.821431559525 ns/iter 1.01
URITemplateRouter_Match 156.3040511813293 ns/iter 156.38451363943307 ns/iter 1.00
URITemplateRouter_Match_BasePath 181.06790366613163 ns/iter 187.9677754146925 ns/iter 0.96
URITemplateRouterView_Restore 8709.10201001378 ns/iter 8728.183615021997 ns/iter 1.00
URITemplateRouterView_Match 124.7678353679755 ns/iter 124.496094532199 ns/iter 1.00
URITemplateRouterView_Match_BasePath 151.02871750990403 ns/iter 144.5383740155129 ns/iter 1.04
URITemplateRouterView_Arguments 484.6363378724304 ns/iter 458.41381606259966 ns/iter 1.06
Pointer_Object_Traverse 29.4364337748155 ns/iter 29.543100761658152 ns/iter 1.00
Pointer_Object_Try_Traverse 22.76533492651598 ns/iter 22.75931304917527 ns/iter 1.00
Pointer_Push_Back_Pointer_To_Weak_Pointer 166.57778938355344 ns/iter 167.86410001067142 ns/iter 0.99
Pointer_Walker_Schema_ISO_Language 1936490.1610169318 ns/iter 2063871.0523077792 ns/iter 0.94
Pointer_Maybe_Tracked_Deeply_Nested/0 1531884.8109890306 ns/iter 1526972.6564550917 ns/iter 1.00
Pointer_Maybe_Tracked_Deeply_Nested/1 1666459.7642856974 ns/iter 1663011.785714053 ns/iter 1.00
Pointer_Position_Tracker_Get_Deeply_Nested 657.1644370234865 ns/iter 689.5104658140588 ns/iter 0.95
JSON_Array_Of_Objects_Unique 400.969418635123 ns/iter 411.5826055723242 ns/iter 0.97
JSON_Parse_1 7450.832405263148 ns/iter 7488.253610235913 ns/iter 1.00
JSON_Parse_Real 6730.365595210392 ns/iter 6748.160433108104 ns/iter 1.00
JSON_Parse_Decimal 9482.423574989147 ns/iter 9596.326373476682 ns/iter 0.99
JSON_Parse_Schema_ISO_Language 5131991.905109549 ns/iter 5116004.058394053 ns/iter 1.00
JSON_Parse_Integer 4862.321536034687 ns/iter 4940.402694949463 ns/iter 0.98
JSON_Parse_String_NonSSO_Plain 8541.436713482462 ns/iter 8538.21594090042 ns/iter 1.00
JSON_Parse_String_SSO_Plain 3592.633817601792 ns/iter 3563.277064388383 ns/iter 1.01
JSON_Parse_String_Escape_Heavy 19285.84424019149 ns/iter 19212.774302896927 ns/iter 1.00
JSON_Parse_Object_Short_Keys 11361.646352530439 ns/iter 11400.819637815626 ns/iter 1.00
JSON_Parse_Object_Scalar_Properties 5822.558293642404 ns/iter 5801.114831039159 ns/iter 1.00
JSON_Parse_Object_Array_Properties 9467.582990695299 ns/iter 9734.380306922903 ns/iter 0.97
JSON_Parse_Object_Object_Properties 9404.947206669189 ns/iter 9659.640886943771 ns/iter 0.97
JSON_Parse_Nested_Containers 74108.05380592469 ns/iter 75981.82852855734 ns/iter 0.98
JSON_From_String_Copy 18.825451967251816 ns/iter 19.882013852529212 ns/iter 0.95
JSON_From_String_Temporary 15.657107260585164 ns/iter 16.721952444257912 ns/iter 0.94
JSON_Number_To_Double 19.712587664137995 ns/iter 19.715276145225733 ns/iter 1.00
JSON_Object_At_Last_Key/8 6.6865007573895126 ns/iter 6.689928485492733 ns/iter 1.00
JSON_Object_At_Last_Key/32 24.535907059279754 ns/iter 23.584989337295575 ns/iter 1.04
JSON_Object_At_Last_Key/128 91.38836811365793 ns/iter 91.10130142216964 ns/iter 1.00
JSON_Object_At_Last_Key/512 379.1929784730104 ns/iter 379.6318659200254 ns/iter 1.00
JSON_Fast_Hash_Helm_Chart_Lock 56.03851008005566 ns/iter 69.38560096272793 ns/iter 0.81
JSON_Equality_Helm_Chart_Lock 153.7803983744967 ns/iter 155.35040296848123 ns/iter 0.99
JSON_Divisible_By_Decimal 231.88112080466166 ns/iter 231.05473699630562 ns/iter 1.00
JSON_String_Equal/10 5.446599568517648 ns/iter 5.646552763249576 ns/iter 0.96
JSON_String_Equal/100 6.146673034547068 ns/iter 6.384142875156882 ns/iter 0.96
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7142656559504911 ns/iter 0.7137591850031626 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 22.011924437726123 ns/iter 21.996787520379378 ns/iter 1.00
JSON_String_Fast_Hash/10 1.055283830030774 ns/iter 1.0553396105344703 ns/iter 1.00
JSON_String_Fast_Hash/100 1.056203588660086 ns/iter 1.0546150980681457 ns/iter 1.00
JSON_String_Key_Hash/10 1.0889343016735809 ns/iter 1.0866667582533815 ns/iter 1.00
JSON_String_Key_Hash/100 15.069977589941821 ns/iter 14.765001782912714 ns/iter 1.02
JSON_Object_Defines_Miss_Same_Length 3.8695859589819532 ns/iter 3.872598429128653 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.994334193332153 ns/iter 3.8710240041872495 ns/iter 1.03
JSON_Object_Defines_Miss_Too_Large 3.5333218965626636 ns/iter 3.517448538034921 ns/iter 1.00
Regex_Lower_S_Or_Upper_S_Asterisk 1.0604868062685588 ns/iter 1.0554187010622762 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.0597104382291453 ns/iter 1.0560747543039875 ns/iter 1.00
Regex_Period_Asterisk 0.704524652731118 ns/iter 0.7037877133679566 ns/iter 1.00
Regex_Group_Period_Asterisk_Group 0.7039895975890922 ns/iter 0.7042290774824117 ns/iter 1.00
Regex_Period_Plus 1.0555760869394422 ns/iter 1.0550176289773516 ns/iter 1.00
Regex_Period 1.0558613493047093 ns/iter 1.0550901263944257 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 0.7044995590645426 ns/iter 0.7037514026670326 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 0.7053239286337898 ns/iter 0.7037042848513348 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 1.0568065348639284 ns/iter 1.0552543471821383 ns/iter 1.00
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.05617736406274 ns/iter 1.0576050455726613 ns/iter 1.00
Regex_Caret_X_Hyphen 4.220667827537595 ns/iter 4.2192791084003725 ns/iter 1.00
Regex_Period_Md_Dollar 34.11918515185908 ns/iter 32.677730553154454 ns/iter 1.04
Regex_Caret_Slash_Period_Asterisk 3.873195316224898 ns/iter 3.868004901230624 ns/iter 1.00
Regex_Caret_Period_Range_Dollar 1.0555340355135698 ns/iter 1.055169802959434 ns/iter 1.00
Regex_Nested_Backtrack 39.463120154298494 ns/iter 43.80866091193796 ns/iter 0.90

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 1b3ab73 into main Jun 19, 2026
12 checks passed
@jviotti jviotti deleted the fix-gcc-2 branch June 19, 2026 20:44

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 615974e Previous: 768e61b Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.5444723092694534 ns/iter 2.823421465599763 ns/iter 0.90
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.178680099270752 ns/iter 2.4627337974173433 ns/iter 0.88
Regex_Period_Asterisk 2.1777638160548523 ns/iter 2.462554403584685 ns/iter 0.88
Regex_Group_Period_Asterisk_Group 2.4913131145040865 ns/iter 2.8151300450411285 ns/iter 0.88
Regex_Period_Plus 3.6692155240403475 ns/iter 2.8145620597347367 ns/iter 1.30
Regex_Period 2.803483510398221 ns/iter 2.4629447456277327 ns/iter 1.14
Regex_Caret_Period_Plus_Dollar 3.022213929967153 ns/iter 2.462149881280867 ns/iter 1.23
Regex_Caret_Group_Period_Plus_Group_Dollar 3.1153461584277915 ns/iter 2.870338829794931 ns/iter 1.09
Regex_Caret_Period_Asterisk_Dollar 3.7549323781472164 ns/iter 4.227275139540043 ns/iter 0.89
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.424306125107452 ns/iter 3.8768809641346396 ns/iter 0.88
Regex_Caret_X_Hyphen 6.698282773304918 ns/iter 6.705470826640378 ns/iter 1.00
Regex_Period_Md_Dollar 28.086703339129038 ns/iter 27.355370975895514 ns/iter 1.03
Regex_Caret_Slash_Period_Asterisk 7.434712616136589 ns/iter 7.705702186431451 ns/iter 0.96
Regex_Caret_Period_Range_Dollar 3.733889351814325 ns/iter 3.8744037174908104 ns/iter 0.96
Regex_Nested_Backtrack 45.93776239964164 ns/iter 37.64728574908752 ns/iter 1.22
JSON_Array_Of_Objects_Unique 408.14048407117224 ns/iter 437.97511645610945 ns/iter 0.93
JSON_Parse_1 4835.473943438832 ns/iter 4644.166976090063 ns/iter 1.04
JSON_Parse_Real 5371.135723657687 ns/iter 5312.588013768137 ns/iter 1.01
JSON_Parse_Decimal 7413.270920392067 ns/iter 7714.196640729245 ns/iter 0.96
JSON_Parse_Schema_ISO_Language 3423270.3170728865 ns/iter 3532356.126262552 ns/iter 0.97
JSON_Parse_Integer 3775.840631784172 ns/iter 3973.469589599689 ns/iter 0.95
JSON_Parse_String_NonSSO_Plain 5123.842262797351 ns/iter 5070.910157886456 ns/iter 1.01
JSON_Parse_String_SSO_Plain 2715.4497682207616 ns/iter 2825.814426787928 ns/iter 0.96
JSON_Parse_String_Escape_Heavy 14319.42742981892 ns/iter 14150.034868661643 ns/iter 1.01
JSON_Parse_Object_Short_Keys 7950.63996310521 ns/iter 7781.843787547572 ns/iter 1.02
JSON_Parse_Object_Scalar_Properties 4017.835293239806 ns/iter 4009.1887467235106 ns/iter 1.00
JSON_Parse_Object_Array_Properties 5731.011333344438 ns/iter 5831.6953063305555 ns/iter 0.98
JSON_Parse_Object_Object_Properties 5694.436662487485 ns/iter 5726.550928306391 ns/iter 0.99
JSON_Parse_Nested_Containers 44859.87483150673 ns/iter 44833.069751024945 ns/iter 1.00
JSON_From_String_Copy 20.65102247235409 ns/iter 23.226723663767928 ns/iter 0.89
JSON_From_String_Temporary 17.526440139497332 ns/iter 20.60322314530678 ns/iter 0.85
JSON_Number_To_Double 24.00989310923514 ns/iter 22.558372305288064 ns/iter 1.06
JSON_Object_At_Last_Key/8 3.694100766203867 ns/iter 3.872097585131473 ns/iter 0.95
JSON_Object_At_Last_Key/32 11.903885994191679 ns/iter 12.954328481339827 ns/iter 0.92
JSON_Object_At_Last_Key/128 48.23920206782003 ns/iter 46.8159890606741 ns/iter 1.03
JSON_Object_At_Last_Key/512 381.43933312785083 ns/iter 368.25893649423153 ns/iter 1.04
JSON_Fast_Hash_Helm_Chart_Lock 60.374791888539384 ns/iter 73.02182350558441 ns/iter 0.83
JSON_Equality_Helm_Chart_Lock 152.0960091095912 ns/iter 159.90493694101707 ns/iter 0.95
JSON_Divisible_By_Decimal 247.95707832493815 ns/iter 245.2193661484036 ns/iter 1.01
JSON_String_Equal/10 6.232695592576374 ns/iter 5.98516554546716 ns/iter 1.04
JSON_String_Equal/100 6.85926055180524 ns/iter 6.6992492038738005 ns/iter 1.02
JSON_String_Equal_Small_By_Perfect_Hash/10 0.934984948132826 ns/iter 1.055220155878515 ns/iter 0.89
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.93592562027332 ns/iter 12.41599255566544 ns/iter 1.20
JSON_String_Fast_Hash/10 2.489566803782517 ns/iter 2.4648363466526213 ns/iter 1.01
JSON_String_Fast_Hash/100 2.49659632757408 ns/iter 2.4633762826371104 ns/iter 1.01
JSON_String_Key_Hash/10 2.745119631388297 ns/iter 2.463199080252761 ns/iter 1.11
JSON_String_Key_Hash/100 9.079695727721775 ns/iter 7.73747310633312 ns/iter 1.17
JSON_Object_Defines_Miss_Same_Length 2.6734159311571735 ns/iter 2.944772811014993 ns/iter 0.91
JSON_Object_Defines_Miss_Too_Small 3.736618091740116 ns/iter 4.23090915878555 ns/iter 0.88
JSON_Object_Defines_Miss_Too_Large 2.8261460235383797 ns/iter 2.942178066126308 ns/iter 0.96
Pointer_Object_Traverse 24.464276896208386 ns/iter 25.518199733646593 ns/iter 0.96
Pointer_Object_Try_Traverse 29.421171290810175 ns/iter 30.79229753835777 ns/iter 0.96
Pointer_Push_Back_Pointer_To_Weak_Pointer 222.9377162254606 ns/iter 195.46967369248196 ns/iter 1.14
Pointer_Walker_Schema_ISO_Language 1765341.9029851654 ns/iter 1811286.7749360632 ns/iter 0.97
Pointer_Maybe_Tracked_Deeply_Nested/0 1208012.053819374 ns/iter 1247997.0553572783 ns/iter 0.97
Pointer_Maybe_Tracked_Deeply_Nested/1 1693069.4414632276 ns/iter 1612400.6307339068 ns/iter 1.05
Pointer_Position_Tracker_Get_Deeply_Nested 704.7438191481243 ns/iter 727.9987533912671 ns/iter 0.97
URITemplateRouter_Create 31858.342243567273 ns/iter 29552.49989414332 ns/iter 1.08
URITemplateRouter_Match 182.5648821702677 ns/iter 183.93962843040862 ns/iter 0.99
URITemplateRouter_Match_BasePath 212.51806045578698 ns/iter 212.59584202469225 ns/iter 1.00
URITemplateRouterView_Restore 7838.322941986641 ns/iter 8731.395323673065 ns/iter 0.90
URITemplateRouterView_Match 141.7610290328317 ns/iter 145.00513742132375 ns/iter 0.98
URITemplateRouterView_Match_BasePath 162.2016812076005 ns/iter 166.81029961373804 ns/iter 0.97
URITemplateRouterView_Arguments 440.9824672931565 ns/iter 454.8742049842062 ns/iter 0.97
JSONL_Parse_Large 9953108.614286065 ns/iter 9294608.310810689 ns/iter 1.07
JSONL_Parse_Large_GZIP 11497549.180327697 ns/iter 11034767.873014508 ns/iter 1.04
HTML_Build_Table_100000 68002042.80000344 ns/iter 69351937.40000615 ns/iter 0.98
HTML_Render_Table_100000 5339653.976744212 ns/iter 5290715.93798439 ns/iter 1.01
GZIP_Compress_ISO_Language_Set_3_Locations 32615438.714287847 ns/iter 35468963.400001034 ns/iter 0.92
GZIP_Decompress_ISO_Language_Set_3_Locations 4065523.168604656 ns/iter 4312563.619631919 ns/iter 0.94
GZIP_Compress_ISO_Language_Set_3_Schema 1865667.9441488194 ns/iter 2111123.0602412936 ns/iter 0.88
GZIP_Decompress_ISO_Language_Set_3_Schema 355368.5215189909 ns/iter 275752.3467297135 ns/iter 1.29
JOSE_VerifySignature_RS256 56908.92784593881 ns/iter 64013.47722699443 ns/iter 0.89
JOSE_VerifySignature_ES512 2453977.9157896447 ns/iter 2676213.6053640074 ns/iter 0.92

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 615974e Previous: 768e61b Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 3.8918325892873487 ns/iter 5.401339999998527 ns/iter 0.72
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.864143415179504 ns/iter 5.220236607142072 ns/iter 0.74
Regex_Period_Asterisk 3.8410340401792302 ns/iter 5.150012500000197 ns/iter 0.75
Regex_Group_Period_Asterisk_Group 3.8449107142873067 ns/iter 5.225621428568924 ns/iter 0.74
Regex_Period_Plus 3.5869993239522393 ns/iter 5.072976785714088 ns/iter 0.71
Regex_Period 3.5721115122759537 ns/iter 4.946532142858879 ns/iter 0.72
Regex_Caret_Period_Plus_Dollar 3.577060106018159 ns/iter 5.3640120000000024 ns/iter 0.67
Regex_Caret_Group_Period_Plus_Group_Dollar 3.575439011472649 ns/iter 4.862591496621294 ns/iter 0.74
Regex_Caret_Period_Asterisk_Dollar 3.8772137276791137 ns/iter 5.201650999997582 ns/iter 0.75
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.841684814569529 ns/iter 5.1541020000013305 ns/iter 0.75
Regex_Caret_X_Hyphen 6.03460624999944 ns/iter 8.253843749998728 ns/iter 0.73
Regex_Period_Md_Dollar 49.45474107139651 ns/iter 47.99945866069296 ns/iter 1.03
Regex_Caret_Slash_Period_Asterisk 5.811353999997664 ns/iter 7.948643268087147 ns/iter 0.73
Regex_Caret_Period_Range_Dollar 4.114975900205047 ns/iter 6.066058999999769 ns/iter 0.68
Regex_Nested_Backtrack 51.20388999998795 ns/iter 57.02226785712941 ns/iter 0.90
JSON_Array_Of_Objects_Unique 398.2866071429011 ns/iter 525.6952678572751 ns/iter 0.76
JSON_Parse_1 7167.630357145072 ns/iter 8839.141741070478 ns/iter 0.81
JSON_Parse_Real 13160.404194628174 ns/iter 16108.796875004471 ns/iter 0.82
JSON_Parse_Decimal 8849.931027089979 ns/iter 11823.171874993932 ns/iter 0.75
JSON_Parse_Schema_ISO_Language 6787249.999998071 ns/iter 7380284.444444543 ns/iter 0.92
JSON_Parse_Integer 4627.833596279507 ns/iter 6108.312499999816 ns/iter 0.76
JSON_Parse_String_NonSSO_Plain 6415.232142857567 ns/iter 7728.023437501009 ns/iter 0.83
JSON_Parse_String_SSO_Plain 2906.9464701138027 ns/iter 3681.3777383036004 ns/iter 0.79
JSON_Parse_String_Escape_Heavy 17427.854712986737 ns/iter 21958.703124994372 ns/iter 0.79
JSON_Parse_Object_Short_Keys 10727.074999998365 ns/iter 13129.053571430763 ns/iter 0.82
JSON_Parse_Object_Scalar_Properties 5397.803571428637 ns/iter 6801.373214285279 ns/iter 0.79
JSON_Parse_Object_Array_Properties 9227.386931305608 ns/iter 11323.434374993725 ns/iter 0.81
JSON_Parse_Object_Object_Properties 9124.353462702662 ns/iter 11496.276785716678 ns/iter 0.79
JSON_Parse_Nested_Containers 66482.71428572018 ns/iter 79328.04687500144 ns/iter 0.84
JSON_From_String_Copy 49.35910999997759 ns/iter 64.10867857141511 ns/iter 0.77
JSON_From_String_Temporary 61.6381160714598 ns/iter 59.90486607142235 ns/iter 1.03
JSON_Number_To_Double 116.08655133932595 ns/iter 122.55691071426813 ns/iter 0.95
JSON_Object_At_Last_Key/8 6.77701099999922 ns/iter 7.2361651785714445 ns/iter 0.94
JSON_Object_At_Last_Key/32 22.927543164214274 ns/iter 23.306654873809226 ns/iter 0.98
JSON_Object_At_Last_Key/128 72.44206473216202 ns/iter 89.52291564629739 ns/iter 0.81
JSON_Object_At_Last_Key/512 332.4992863279635 ns/iter 420.19069958342766 ns/iter 0.79
JSON_Fast_Hash_Helm_Chart_Lock 59.20946000001096 ns/iter 63.545107142845474 ns/iter 0.93
JSON_Equality_Helm_Chart_Lock 250.70330907315724 ns/iter 305.70241677426253 ns/iter 0.82
JSON_Divisible_By_Decimal 321.24783144499617 ns/iter 305.2587583417572 ns/iter 1.05
JSON_String_Equal/10 12.267014007732312 ns/iter 16.91806890104978 ns/iter 0.73
JSON_String_Equal/100 15.143261160720353 ns/iter 17.785840952323657 ns/iter 0.85
JSON_String_Equal_Small_By_Perfect_Hash/10 1.740702055125798 ns/iter 2.5548412030753838 ns/iter 0.68
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 12.781991071433042 ns/iter 14.263270248824128 ns/iter 0.90
JSON_String_Fast_Hash/10 3.980175528604947 ns/iter 4.933559000000969 ns/iter 0.81
JSON_String_Fast_Hash/100 3.9608715786317674 ns/iter 5.179097344904343 ns/iter 0.76
JSON_String_Key_Hash/10 4.284981956635018 ns/iter 5.4784651785675065 ns/iter 0.78
JSON_String_Key_Hash/100 9.722590135166746 ns/iter 12.17206249999947 ns/iter 0.80
JSON_Object_Defines_Miss_Same_Length 3.9232101054765107 ns/iter 4.368472832871895 ns/iter 0.90
JSON_Object_Defines_Miss_Too_Small 4.531889456193044 ns/iter 5.460547000002407 ns/iter 0.83
JSON_Object_Defines_Miss_Too_Large 3.344380083312112 ns/iter 4.740323214284509 ns/iter 0.71
Pointer_Object_Traverse 54.869026785695496 ns/iter 70.95049107143886 ns/iter 0.77
Pointer_Object_Try_Traverse 53.2333799999833 ns/iter 74.12666071429288 ns/iter 0.72
Pointer_Push_Back_Pointer_To_Weak_Pointer 120.99994642856669 ns/iter 186.0047844646815 ns/iter 0.65
Pointer_Walker_Schema_ISO_Language 7088714.444444121 ns/iter 7255867.777778096 ns/iter 0.98
Pointer_Maybe_Tracked_Deeply_Nested/0 1948443.1635385714 ns/iter 2446205.220884764 ns/iter 0.80
Pointer_Maybe_Tracked_Deeply_Nested/1 2992995.3389829295 ns/iter 3613957.2192498846 ns/iter 0.83
Pointer_Position_Tracker_Get_Deeply_Nested 446.65330357166306 ns/iter 526.2981855250687 ns/iter 0.85
URITemplateRouter_Create 31053.299107140574 ns/iter 39922.06488306541 ns/iter 0.78
URITemplateRouter_Match 153.13339285713465 ns/iter 191.07692227328454 ns/iter 0.80
URITemplateRouter_Match_BasePath 173.9179424499103 ns/iter 222.1810000000346 ns/iter 0.78
URITemplateRouterView_Restore 19011.012350522713 ns/iter 31138.767857145565 ns/iter 0.61
URITemplateRouterView_Match 126.6991964285223 ns/iter 160.23256696422143 ns/iter 0.79
URITemplateRouterView_Match_BasePath 142.1473195470566 ns/iter 177.4101480407873 ns/iter 0.80
URITemplateRouterView_Arguments 452.19144137732366 ns/iter 533.2875892857405 ns/iter 0.85
JSONL_Parse_Large 25179403.571428336 ns/iter 33675709.99998861 ns/iter 0.75
JSONL_Parse_Large_GZIP 25679611.53846017 ns/iter 36966105.00001043 ns/iter 0.69
HTML_Build_Table_100000 74015322.2221933 ns/iter 98489844.44442977 ns/iter 0.75
HTML_Render_Table_100000 7156616.964286805 ns/iter 7494970.000000953 ns/iter 0.95
GZIP_Compress_ISO_Language_Set_3_Locations 28247876.000004906 ns/iter 37542436.84211121 ns/iter 0.75
GZIP_Decompress_ISO_Language_Set_3_Locations 7667516.666667022 ns/iter 9986185.333333801 ns/iter 0.77
GZIP_Compress_ISO_Language_Set_3_Schema 1716922.5446421267 ns/iter 2173906.2500003567 ns/iter 0.79
GZIP_Decompress_ISO_Language_Set_3_Schema 430334.4786013929 ns/iter 620544.9107142158 ns/iter 0.69
JOSE_VerifySignature_RS256 18372.389039183017 ns/iter 21486.617143527663 ns/iter 0.86
JOSE_VerifySignature_ES512 1180502.5000001024 ns/iter 1542335.7142856682 ns/iter 0.77

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant