Implement a convenience release.sh script#1007
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Adds a simple, repo-local release workflow that centralizes versioning and automates tagging. Changes:
MAJOR.MINOR.PATCH format and the script performs in-place updates of the VERSION file.
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| @@ -1,5 +1,7 @@ | |||
| cmake_minimum_required(VERSION 3.16) | |||
| project(one VERSION 6.3.0 LANGUAGES C CXX) | |||
| file(READ "${CMAKE_CURRENT_LIST_DIR}/VERSION" ONE_PROJECT_VERSION) | |||
There was a problem hiding this comment.
CMakeLists.txt:2 file(READ ...) doesn’t automatically cause CMake to reconfigure when VERSION changes, so an existing build directory can keep reporting the old project version until the user manually reruns CMake.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
|
||
| BUMP_TYPE="$1" | ||
|
|
||
| CURRENT_VERSION="$(cat VERSION)" |
There was a problem hiding this comment.
release.sh:17 This reads VERSION from the current working directory, so running the script from anywhere other than the repo root will fail (or read the wrong VERSION file if one exists elsewhere).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| echo "Error: ${CURRENT_VERSION} not found in ${file}" 1>&2 | ||
| exit 1 | ||
| fi | ||
| sed -i.bak "s/${CURRENT_VERSION}/${NEW_VERSION}/g" "$file" |
There was a problem hiding this comment.
release.sh:50 Using ${CURRENT_VERSION} unescaped in grep/sed treats dots as regex wildcards, which can match/replace unintended strings (e.g., 6.3.0 matches 6x3y0).
Severity: medium
Other Locations
release.sh:45
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| replace_version VERSION | ||
|
|
||
| git add VERSION | ||
| git commit --gpg-sign --signoff --message "v${NEW_VERSION}" |
There was a problem hiding this comment.
release.sh:57 If the user already has staged changes, git commit will include them along with the version bump, which can accidentally ship unrelated modifications in the release commit.
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: f63b62f | Previous: d122743 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
392 ms |
411 ms |
0.95 |
Add one schema (100 existing) |
30 ms |
30 ms |
1 |
Add one schema (1000 existing) |
90 ms |
87 ms |
1.03 |
Add one schema (10000 existing) |
988 ms |
790 ms |
1.25 |
Update one schema (1 existing) |
22 ms |
22 ms |
1 |
Update one schema (101 existing) |
31 ms |
30 ms |
1.03 |
Update one schema (1001 existing) |
92 ms |
87 ms |
1.06 |
Update one schema (10001 existing) |
735 ms |
719 ms |
1.02 |
Cached rebuild (1 existing) |
7 ms |
6 ms |
1.17 |
Cached rebuild (101 existing) |
9 ms |
9 ms |
1 |
Cached rebuild (1001 existing) |
31 ms |
29 ms |
1.07 |
Cached rebuild (10001 existing) |
271 ms |
250 ms |
1.08 |
Index 100 schemas |
682 ms |
665 ms |
1.03 |
Index 1000 schemas |
1545 ms |
1664 ms |
0.93 |
Index 10000 schemas |
13627 ms |
13765 ms |
0.99 |
Index 10000 schemas (custom meta-schema) |
138630 ms |
148260 ms |
0.94 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: f63b62f | Previous: d122743 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
409 ms |
396 ms |
1.03 |
Add one schema (100 existing) |
34 ms |
33 ms |
1.03 |
Add one schema (1000 existing) |
95 ms |
95 ms |
1 |
Add one schema (10000 existing) |
748 ms |
847 ms |
0.88 |
Update one schema (1 existing) |
26 ms |
25 ms |
1.04 |
Update one schema (101 existing) |
33 ms |
32 ms |
1.03 |
Update one schema (1001 existing) |
97 ms |
93 ms |
1.04 |
Update one schema (10001 existing) |
752 ms |
755 ms |
1.00 |
Cached rebuild (1 existing) |
8 ms |
8 ms |
1 |
Cached rebuild (101 existing) |
10 ms |
10 ms |
1 |
Cached rebuild (1001 existing) |
34 ms |
33 ms |
1.03 |
Cached rebuild (10001 existing) |
273 ms |
274 ms |
1.00 |
Index 100 schemas |
646 ms |
656 ms |
0.98 |
Index 1000 schemas |
1601 ms |
1589 ms |
1.01 |
Index 10000 schemas |
13574 ms |
13666 ms |
0.99 |
Index 10000 schemas (custom meta-schema) |
135379 ms |
135757 ms |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
1 participant
Signed-off-by: Juan Cruz Viotti jv@jviotti.com