ParaView: add option to enable extra hdf5 based IO modules#3483
Open
kwryankrattiger wants to merge 1 commit intospack:developfrom
Open
ParaView: add option to enable extra hdf5 based IO modules#3483kwryankrattiger wants to merge 1 commit intospack:developfrom
kwryankrattiger wants to merge 1 commit intospack:developfrom
Conversation
kwryankrattiger
force-pushed
the
paraview_hdf5_extras
branch
3 times, most recently
from
ec2e149 to
f3cb9f3
Compare
kwryankrattiger
changed the title
kwryankrattiger
changed the title
kwryankrattiger
force-pushed
the
paraview_hdf5_extras
branch
from
f3cb9f3 to
e923753
Compare
Member
vicentebolea
left a comment
vicentebolea
left a comment
There was a problem hiding this comment.
looks good, just some questions to understand it better.
johnwparent
previously approved these changes
Mar 2, 2026
Contributor
johnwparent
left a comment
johnwparent
left a comment
There was a problem hiding this comment.
One nit that can be ignored, looks good.
The IO related variants still need to better reflect what is denoted by the build edition. Currently it is opaque to the Spack user if an IO module is enabled or not as decisions around defaults change and are not adequately exposed via variants. Signed-off-by: Ryan Krattiger <ryan.krattiger@kitware.com>
kwryankrattiger
force-pushed
the
paraview_hdf5_extras
branch
from
e923753 to
a54449a
Compare
boonth
reviewed
Mar 24, 2026
| @@ -182,6 +192,14 @@ class Paraview(CMakePackage, CudaPackage, ROCmPackage): | |||
| when="%xl_r", | |||
| msg="Use paraview@5.9.0 with %xl_r. Earlier versions are not able to build with xl.", | |||
| ) | |||
| # Require HDF5 and MPI for the extra HDF5 based readers | |||
| conflicts("+hdf5_extra", when="~hdf5") | |||
There was a problem hiding this comment.
@kwryankrattiger Could you add an error message here?
Suggested change
| conflicts("+hdf5_extra", when="~hdf5") | |
| conflicts("+hdf5_extra", when="~hdf5", msg="hdf5_extra needs hdf5") |
boonth
reviewed
Mar 24, 2026
| @@ -182,6 +192,14 @@ class Paraview(CMakePackage, CudaPackage, ROCmPackage): | |||
| when="%xl_r", | |||
| msg="Use paraview@5.9.0 with %xl_r. Earlier versions are not able to build with xl.", | |||
| ) | |||
| # Require HDF5 and MPI for the extra HDF5 based readers | |||
| conflicts("+hdf5_extra", when="~hdf5") | |||
| conflicts("+hdf5_extra", when="~mpi") | |||
There was a problem hiding this comment.
@kwryankrattiger Same as above, could you add an error message here?
Suggested change
| conflicts("+hdf5_extra", when="~mpi") | |
| conflicts("+hdf5_extra", when="~mpi", msg="hdf5_extra needs mpi") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IO related variants still need to better reflect what is denoted by the build edition. Currently it is opaque to the Spack user if an IO module is enabled or not as decisions around defaults change and are not adequately exposed via variants.