Add search on synonyms in the QB

[CarolineDenis]

Fixes #752

Checklist

• Self-review the PR after opening it to make sure the changes look good
  and self-explanatory (or properly documented)
• Add relevant issue to release milestone

Testing instructions

• open query builder and select a tree table
• make a search on any rank
• add name field in the mapper line
• enter the name of a node that has a synonym for the value
• check the box search synonyms
• run the query
• verify that the node is being return as well as its synonym

[gitguardian]

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

---

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

[emenslin]

This does not appear to be working unless I am misunderstanding the instructions. I query on any rank -> name and set equal to a taxon that has synonyms but when I check 'search synonyms' only the one node appears.

If I check 'search synonyms' in any tree aside from taxon I get an error.

11-07_15.21.mp4

Specify 7 Crash Report - 2025-11-07T21_21_43.622Z.txt

[grantfitzsimmons]

The fundamental issue here is that 'Search Synonyms' is used most often for searching Collection Objects rather than tree names via a tree base table. The inadequate request this PR is based on unfortunately did not clarify this well enough.

See #752 (comment):

Hey guys, this one is quite important. If I create a collection object query and search for a preferred taxon name, it does not return collection objects with the original taxon name that are different (i.e. junior synonyms) to the preferred taxon name. The functionality is as expected in Specify 6.

Also related to this is that when querying collection objects from a taxon name in the taxon tree, the behaviour differs from Specify 6. In 6 you get records where either the taxon name or the preferred taxon name match the searched name, but in 7 it only searches on taxon name, so searches for a senior synonym don't return collection objects identified as the junior synonyms.

See that if I search for a synonym in a database (e.g. Opsanus tau) with Collection Object as the base table, I can still check "Search Synonyms":

In the results:

This same behavior is expected in 7.

---

Using a copy of herb_rbge, I see the following:

Left: v7.11.2.1, Right: issue-752

Same query, exported and imported in both: Taxon Synonyms.json

On the v7.11.2.1, only results where synonyms do have an ID that isn't empty are returned (67532). On issue-752, all taxon records are returned (370611).

In neither scenario is "Search Synonyms" checked.

---

Searching directly for a Full Name for a synonymized node (e.g. Ericaceae) does yield correct results when querying Taxon directly:

[acwhite211]

The example query is returning the correct number of records now (65984)

[grantfitzsimmons]

@acwhite211 Is this a draft or can it be tested?

[bhumikaguptaa]

• verify that the node is being returned as well as its synonym

I am able to see the node and the synonym. Looks good to me!

[emenslin]

• verify that the node is being return as well as its synonym

---

General functionality seems good but the testing instructions seem to be lacking after Grants comment (i.e. now search synonyms appear with CO as a base table but that is not mentioned in the testing instructions at all), I don't want to approve without further clarification on the testing instructions in case I miss anything.

Should the Search Synonyms checkbox work similarly to the Series checkbox, so that it only appears when there is some sort of tree information in the query? Not necessarily an issue, since it's the same in 6, I just wanted to mention it

02-24_09.36.mp4