Open
Conversation
The counters attribute array made the dash calculations go wrong. For example: a two-point line with a dashArray value of 0.5 would only give 1 dash instead of (1/0.5 =) 2. This altered counters calculation fixes that.
robksawyer
added a commit
to robksawyer/THREE.MeshLine
that referenced
this pull request
Dec 23, 2021
Contributor
|
i've merged your commit to https://github.com/pmndrs/meshline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counters attribute array made the dash calculations go wrong.
For example: a two-point line with a dashArray value of 0.5 would only give 1 dash instead of (1/0.5 =) 2.
(See plot of opacity/alpha value here.)
This altered counters calculation fixes that.