Merged
Conversation
ppadb.command.transport: Transport.shell() misses return, when a custom handler is supplied it's never used because of a missing return making the feature useless.
Fix SyntaxWarning during build
Owner
|
Thanks for the PR, I'll take a look over it. I need to merge #3 first, and that should add a pipeline with testing. |
Author
|
Great! I've updated the various metadata; to nominate you as the package owner basically going forward. CloCkWeRX#1 I've also done to make sure the build is green ahead of #3 - which it seems to be.
|
CloCkWeRX
added a commit
to CloCkWeRX/python-androidtv
that referenced
this pull request
Feb 9, 2025
Diff between the published package and this repo is: Swind/pure-python-adb@master...spm5065:pure-python-adb:master And potentially spm5065/pure-python-adb#4
spm5065
requested changes
Feb 17, 2025
Owner
spm5065
left a comment
spm5065
left a comment
There was a problem hiding this comment.
Looks good.
I have one question regarding the update to uninstall(). Otherwise, it should just get rebased, then I will merge this in.
Thanks for the work!
Closed
spm5065
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges:
You already adopted some of these, so the only differences are were there were conflicts.
Additionally provides what should be a fix for:
Finally, runs
blackto clean up source.Fix Swind#87