Make BinderHeaders.BATCH_HEADERS final (fixes #3182)#3184
Open
wadhwaroh-lang wants to merge 1 commit intospring-cloud:mainfrom
Open
Make BinderHeaders.BATCH_HEADERS final (fixes #3182)#3184wadhwaroh-lang wants to merge 1 commit intospring-cloud:mainfrom
wadhwaroh-lang wants to merge 1 commit intospring-cloud:mainfrom
Conversation
Signed-off-by: wadhwaroh-lang <wadhwa.roh@gmail.com>
wadhwaroh-lang
force-pushed
the
fix/3182-binder-headers-batch-final
branch
from
7de30a0 to
a5c1e94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3182
Problem
BinderHeaders.BATCH_HEADERSis apublic static Stringand is notfinal, so the header key could be reassigned by callers.Solution
Mark
BATCH_HEADERSasfinal, consistent with other constants inBinderHeaders(e.g.TARGET_DESTINATION,PARTITION_HEADER). This keeps the header name immutable and prevents accidental modification.Changes
core/spring-cloud-stream/src/main/java/org/springframework/cloud/stream/binder/BinderHeaders.java:public static String BATCH_HEADERS→public static final String BATCH_HEADERS