GH-3142: Clarify republishToDlq default behaviour in docs#3199
Open
won-seoop wants to merge 1 commit into
Open
GH-3142: Clarify republishToDlq default behaviour in docs#3199won-seoop wants to merge 1 commit into
won-seoop wants to merge 1 commit into
Conversation
The previous description opened with "By default, messages that fail after retries are exhausted are rejected", which implies the default is false (reject). The actual default is true (republish with extra headers). Rewrite the description to lead with the true default behaviour and describe the false case explicitly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3142.
The previous description of
republishToDlqopened with:This sentence implies the default is
false(reject on failure). However the actual default istrue(republish to the DLQ with additional error headers). The misleading opening was a carry-over from when the default wasfalseand was later changed.This PR rewrites the description to:
true(default) behaviour: binder republishes with extra headers.falsebehaviour explicitly: rejected; RabbitMQ routes unchanged to DLQ if one is configured.No code changes — docs only.
Test plan
Default: truewith a matching prose description.🤖 Generated with Claude Code